Skip to content

test: remove hardcoded queue integration timeout#432

Draft
sbalabanov wants to merge 3 commits into
mainfrom
fix/messagequeue-test-completion
Draft

test: remove hardcoded queue integration timeout#432
sbalabanov wants to merge 3 commits into
mainfrom
fix/messagequeue-test-completion

Conversation

@sbalabanov

@sbalabanov sbalabanov commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • coordinate concurrent MySQL message-queue test receivers through one shared result channel
  • keep message aggregation and duplicate tracking exclusively on the main test goroutine, without mutexes or a wait group
  • acknowledge each delivery before reporting it, cancel on successful completion or the first real worker error, and consume every worker's terminal result before returning
  • distinguish expected context cancellation after completion/error from standalone cancellation that must fail the test
  • remove local integration-test safety timeouts and rely on Bazel's test timeout for stuck tests

Benchmark

Uncached Bazel test attempt runtime:

  • before: 58.3s
  • after: 38.3s
  • improvement: 20.0s (~34%)

Tests

  • ./tool/bazel test //test/integration/extension/messagequeue/mysql:go_default_test --nocache_test_results --test_output=errors --strategy=TestRunner=local ...
  • ./tool/bazel test //test/integration/extension/messagequeue/mysql:go_default_test --nocache_test_results --test_output=errors --strategy=TestRunner=local --@rules_go//go/config:race ...
  • make fmt
  • make lint
  • make check-tidy
  • make check-gazelle

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Comment thread test/integration/extension/messagequeue/mysql/queue_test.go Outdated
@sbalabanov sbalabanov changed the title test: stop message queue receivers on completion test: remove hardcoded queue integration timeout Jul 23, 2026
Comment thread test/integration/extension/messagequeue/mysql/queue_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants