feat(cli): experimental --local-bundle deploy mode#4331
Open
myftija wants to merge 14 commits into
Open
Conversation
…ment flag Schema groundwork for pre-bundled deploys: the CLI bundles locally and uploads the build context as a deployment_bundle artifact; fromBundle on the initialize request and BuildServerMetadata signals that the build server should skip install/bundle and only run the container build.
--local-bundle: bundle locally (install + esbuild, same as the classic path), upload only the resulting build context as a deployment_bundle artifact, and let the build server run just the container build. Env-var sync happens client-side since the build server never sees the unscrubbed manifest. The build-arg values (scrubbed from build.json) travel in trigger-build-args.json, excluded from the image COPY context via a generated .dockerignore. --from-bundle <dir> (hidden): build the deployment image from a pre-built bundle directory, skipping config loading and bundling entirely, used by the build server's nested deploy for pre-bundled artifacts. Reuses the extracted buildAndFinalizeDeployment tail shared with the classic path. Bundle archives use a dedicated archiver: the source-context ignores (dist, build, .trigger) would strip the bundle output itself.
…e to build enqueue The artifacts endpoint accepts the new bundle type (same key prefix and size limit as deployment contexts), and initializeDeployment persists fromBundle in the build server metadata and passes it through the enqueue-build options so the build job can skip install/bundle.
- --local-bundle now respects --dry-run (build the bundle, print its path, stop before any upload or deployment initialization) - append to an existing .dockerignore in the bundle output instead of clobbering one a build extension may have written - send config.runtime on initialization, identical to classic native deploys, instead of the resolved manifest runtime - bundle artifacts get a distinct 'bundles/' key prefix so the build server can recognize a bundle even if the fromBundle flag is stripped by schema skew along the enqueue chain
- sync env vars BEFORE initializing the deployment: initialization enqueues the remote build synchronously, so a post-init sync raced a fast build, a run triggered right after promotion could execute without the synced vars - keep the bundle dir on --dry-run so the printed path is inspectable - always append the build-args exclusions as the LAST .dockerignore lines so a pre-existing negation cannot re-include them - warn when --from-bundle initializes a fresh deployment (attach mode is the supported flow)
Local docker builds and the dev build-server harness reach the dev webapp as host.docker.internal (e.g. the in-build indexer fetching env vars); Vite's default host blocking rejected those requests since the Vite migration.
The container build runs on the build server with fixed settings, so local build-tuning flags (--compression, --no-cache, --builder, --network, --push, --load, ...) are parsed but not forwarded. Warn instead of silently dropping them, depot honored these flags, so local-bundle users migrating from depot would otherwise assume they took effect.
Covers the cross-path contract: contents at archive root (extracted without stripping), dotfiles and nested .trigger/skills included, node_modules/.DS_Store excluded, dist-like names NOT excluded (the bundle is build output), empty-dir error.
🦋 Changeset detectedLatest commit: 5cf331f The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe CLI adds 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview Deployment
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- wrap the bundle JSON parses in real try/catch so a corrupt build.json or trigger-build-args.json surfaces the intended error message instead of a raw SyntaxError (the eager JSON.parse threw before tryCatch could see it) - upsert the preview branch on fresh-init from-bundle deploys, matching the main deploy path (attach mode already has the branch env)
myftija
force-pushed
the
feature/local-bundle-deploy-tri-12120
branch
from
July 22, 2026 09:43
9a6681d to
b9ba358
Compare
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
isCloud() only matched the hardcoded cloud origins, so PR preview environments never initialized the billing client and anything gated on it silently no-op'd. Most visibly: remote builds were never enqueued and deployments sat queued forever. Preview origins now count as cloud.
Comment on lines
+1791
to
+1802
| const deployment = await initializeOrAttachDeployment( | ||
| projectClient.client, | ||
| { | ||
| contentHash: bundleManifest.contentHash, | ||
| type: "MANAGED", | ||
| runtime: bundleManifest.runtime, | ||
| isLocalBuild: true, | ||
| isNativeBuild: false, | ||
| triggeredVia: getTriggeredVia(), | ||
| }, | ||
| existingDeploymentId | ||
| ); |
Contributor
There was a problem hiding this comment.
🔍 handleFromBundleDeploy hardcodes type: MANAGED regardless of project engine
handleFromBundleDeploy always initializes with type: "MANAGED" (deploy.ts:1795), unlike the classic path which uses features.run_engine_v2 ? "MANAGED" : "V1". In attach mode the type is ignored (the existing deployment is reused), so this only affects fresh-init from a bundle, which is the documented testing-only path. A V1 project fresh-initialized from a bundle would be forced to MANAGED. Low impact given the constraints, but worth confirming the build-server flow always attaches.
Was this helpful? React with 👍 or 👎 to provide feedback.
The bundler emits the controller entry points at paths mirroring the CLI's install location, which contains a node_modules segment when the CLI runs via npx. The archiver's blanket node_modules exclusion silently stripped them from the uploaded bundle, so the image build failed at the indexer stage with MODULE_NOT_FOUND. Only .DS_Store is excluded now.
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/cli-v3/src/deploy/bundleArchive.ts (1)
21-44: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winSort the glob results before creating the archive.
tinyglobbydoesn’t guarantee result order, andtar.createpreserves the input order, so identical bundles can produce different archive bytes.Source: MCP tools
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: a238d3fd-7876-4002-a236-60cd2139b13a
📒 Files selected for processing (2)
packages/cli-v3/src/deploy/bundleArchive.test.tspackages/cli-v3/src/deploy/bundleArchive.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (23)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (11, 12)
- GitHub Check: e2e / 🧪 CLI v3 tests (warp-ubuntu-latest-x64-4x - npm)
- GitHub Check: sdk-compat / Node.js 24.18 (warp-ubuntu-latest-x64-4x)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 12)
- GitHub Check: sdk-compat / Node.js 20.20 (warp-ubuntu-latest-x64-4x)
- GitHub Check: packages / 🧪 Unit Tests: Packages (3, 3)
- GitHub Check: e2e / 🧪 CLI v3 tests (warp-ubuntu-latest-x64-4x - pnpm)
- GitHub Check: packages / 🧪 Unit Tests: Packages (2, 3)
- GitHub Check: sdk-compat / Node.js 22.23 (warp-ubuntu-latest-x64-4x)
- GitHub Check: sdk-compat / Deno Runtime
- GitHub Check: sdk-compat / Node.js 26.4 (warp-ubuntu-latest-x64-4x)
- GitHub Check: sdk-compat / Bun Runtime
- GitHub Check: sdk-compat / Cloudflare Workers
- GitHub Check: packages / 🧪 Unit Tests: Packages (1, 3)
- GitHub Check: typecheck / typecheck
- GitHub Check: runops-guard / runops-guard
- GitHub Check: code-quality / code-quality
- GitHub Check: audit
- GitHub Check: 🛡️ E2E Auth Tests (full)
- GitHub Check: audit
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Build and publish previews
🧰 Additional context used
📓 Path-based instructions (6)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
**/*.{ts,tsx}: Prefer static imports over dynamicimport(); use dynamic imports only for unresolvable circular dependencies, genuine performance code splitting, or conditional runtime loading.
Import Trigger.dev tasks from@trigger.dev/sdk; never use@trigger.dev/sdk/v3or deprecatedclient.defineJob.
Add agentcrumbs while writing code using approved namespaces; mark lines with//@Crumbsor blocks with `// `#region` `@crumbs, and strip them before merging.
Files:
packages/cli-v3/src/deploy/bundleArchive.tspackages/cli-v3/src/deploy/bundleArchive.test.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
Files:
packages/cli-v3/src/deploy/bundleArchive.tspackages/cli-v3/src/deploy/bundleArchive.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
packages/cli-v3/src/deploy/bundleArchive.tspackages/cli-v3/src/deploy/bundleArchive.test.ts
packages/cli-v3/src/deploy/**/*
📄 CodeRabbit inference engine (packages/cli-v3/CLAUDE.md)
Deploy mode code should be located in
src/deploy/and handles bundling, archiving, building Docker images, and pushing to registry
Files:
packages/cli-v3/src/deploy/bundleArchive.tspackages/cli-v3/src/deploy/bundleArchive.test.ts
packages/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
For public packages, use
buildfor verification.
Files:
packages/cli-v3/src/deploy/bundleArchive.tspackages/cli-v3/src/deploy/bundleArchive.test.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
**/*.{test,spec}.{ts,tsx}: Use Vitest exclusively and never mock dependencies; use Testcontainers for integration dependencies.
Place test files next to the source files they test.
Files:
packages/cli-v3/src/deploy/bundleArchive.test.ts
🧠 Learnings (12)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
packages/cli-v3/src/deploy/bundleArchive.tspackages/cli-v3/src/deploy/bundleArchive.test.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
packages/cli-v3/src/deploy/bundleArchive.tspackages/cli-v3/src/deploy/bundleArchive.test.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
packages/cli-v3/src/deploy/bundleArchive.tspackages/cli-v3/src/deploy/bundleArchive.test.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
packages/cli-v3/src/deploy/bundleArchive.tspackages/cli-v3/src/deploy/bundleArchive.test.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
packages/cli-v3/src/deploy/bundleArchive.tspackages/cli-v3/src/deploy/bundleArchive.test.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
packages/cli-v3/src/deploy/bundleArchive.tspackages/cli-v3/src/deploy/bundleArchive.test.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
packages/cli-v3/src/deploy/bundleArchive.tspackages/cli-v3/src/deploy/bundleArchive.test.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
packages/cli-v3/src/deploy/bundleArchive.tspackages/cli-v3/src/deploy/bundleArchive.test.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
packages/cli-v3/src/deploy/bundleArchive.tspackages/cli-v3/src/deploy/bundleArchive.test.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In this repo’s trigger.dev codebase, the “never mock — use testcontainers” guideline should only be applied to integration tests that talk to real external services (e.g., Redis, Postgres, S2). For unit tests that validate in-memory logic (e.g., deduplication/cache behavior in StandardRealtimeStreamsManager and similar module-boundary call counting), it is allowed to use Vitest mocks like `vi.fn()` and to stub/mock `ApiClient` objects to count calls or simulate in-process collaborators. Do not flag `vi.fn()`-based mocks as policy violations in these unit-test scenarios; reserve the rule for true external-service integration tests.
Applied to files:
packages/cli-v3/src/deploy/bundleArchive.test.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
packages/cli-v3/src/deploy/bundleArchive.test.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
packages/cli-v3/src/deploy/bundleArchive.test.ts
🔇 Additional comments (2)
packages/cli-v3/src/deploy/bundleArchive.ts (1)
8-11: LGTM!packages/cli-v3/src/deploy/bundleArchive.test.ts (1)
63-69: LGTM!Also applies to: 92-107
…oyment Replaces the trigger-build-args.json file and generated .dockerignore: the bundle artifact is now secret-free. Build-arg values are sent with the init request, stored aes-256-gcm encrypted in a new WorkerDeployment.buildEnvVars column, and cleared on every terminal status transition. - new dedicated GET /api/v1/deployments/:id/build-env-vars endpoint, used by the from-bundle build in attach mode; returns an empty record for terminal deployments and never 500s on a bad envelope - size limits enforced server-side and pre-checked client-side (128 KiB serialized, 200 keys) - version-skew guard: the CLI hard-errors when it sent vars and the server did not ack storing them
Extensions can set undefined values at runtime (e.g. env?.MISSING_VAR) despite the manifest type. JSON serialization strips them, so the client side emptiness check disagreed with what the server received and the version-skew guard misfired.
Review feedback: a corrupt or undecryptable envelope previously returned an empty record, indistinguishable from no vars at all, letting the remote build run without its build-time secrets. The endpoint now returns an error so the build aborts with an actionable message. An empty record remains the response only for deployments that genuinely have none or are terminal. Also cancel the deployment best-effort when the version-skew guard aborts, instead of leaving it pending until the queue timeout reaps it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an experimental
--local-bundleflag to native build deployments: the project is installed and bundled on the local machine (exactly like in the depot path) and only the resulting build context is uploaded. The remote build then runs just the container image build.Design
WorkerDeployment.buildEnvVarscolumn, and cleared on every terminal status transition. They exist at rest only for the active build window, always encrypted.GET /api/v1/deployments/:id/build-env-varsendpoint returns the decrypted values to the same principals that can already read the environment's variables. It answers with an empty record for deployments without stored values or in a terminal state, keeping secret access to a single auditable route.--from-bundle <dir>mode builds a deployment image straight from such a bundle directory, skipping config loading and bundling entirely. In attach mode it fetches the stored build-arg values through the new endpoint.syncEnvVarsextension) happens client side, before the deployment initializes, since the remote side never sees the unscrubbed manifest.