Skip to content

Fix service pending request gauge cleanup#11186

Draft
taylan-oai wants to merge 4 commits into
temporalio:mainfrom
taylan-oai:dev/taylan/fix-service-pending-requests-metric
Draft

Fix service pending request gauge cleanup#11186
taylan-oai wants to merge 4 commits into
temporalio:mainfrom
taylan-oai:dev/taylan/fix-service-pending-requests-metric

Conversation

@taylan-oai

Copy link
Copy Markdown

What changed

  • record ServicePendingRequests after request cleanup as well as admission
  • keep pending-request metric updates ordered by emitted operation series when limiter buckets differ
  • add regression coverage for completion, rejection, concurrent updates, and Nexus operation series

Validation

  • go test -tags test_dep ./common/rpc/interceptor
  • go test -tags test_dep ./service/frontend -run TestNexus
  • go test -tags disable_grpc_modules,test_dep ./common/rpc/... -count=1
  • make lint-code

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants