Record value types as out of scope (ADR-0007)#23
Merged
Conversation
Structured value types (a top-level `types:` section with named, typed fields) cross the IDL line the format resists: named typed fields define record structure — implementation detail modelith abstracts away. A value-shaped concept is modeled as an owned entity or as attributes on its owner, with rules stated as prose. - ADR-0007 records the decision (supersedes ADR-0005, which had decided to build value types; nothing was implemented). - ADR-0005 marked superseded via Status frontmatter; body kept as the historical record. - Schema reference reframes value objects from "being explored (#11)" to a settled omission. Closes #11. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Joe Beda <joe@stacklok.com>
ADR-0006 cited ADR-0005 as precedent for "rules and shapes stay prose," but ADR-0005 declared value-type shape via typed fields — the exact move ADR-0007 now rejects as crossing the IDL line. Point the citation at ADR-0007, the live holder of that line, now that 0005 is superseded. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Joe Beda <joe@stacklok.com>
Contributor
Author
Review round 1 (docs-only, single Sonnet reviewer pass)Per
Verified clean: schema/code have no |
jbeda
marked this pull request as ready for review
July 22, 2026 01:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts issue #11 (structured value types). On revisiting the
types:shapebefore building, we decided a top-level section of named, typed fields defines
record structure — an implementation detail the format abstracts away, and the
IDL line modelith deliberately holds (the same line ADR-0006 held for action
reports). A value-shaped concept is modeled as an owned entity or as attributes
on its owner, with rules stated as prose.
Changes
project-docs/adr/0007-value-types-out-of-scope.md(new) — records thedecision; supersedes ADR-0005. Framed "for now, not never": the reopen bar is
a concrete modeling failure, not expressiveness for its own sake.
project-docs/adr/0005-value-types.md—Status: superseded by ADR-0007frontmatter; body left intact as the historical record (decisions aren't
edited in place).
docs/06-schema-reference.md— value objects reframed from "beingexplored (Schema: value types (structured attribute types, lists) #11)" to a settled omission under "what this format deliberately
leaves out."
Docs/ADR-only; no code, schema, or renderer change. Closes #11.
🤖 Generated with Claude Code