fix: version the drivers that gained a control path#32
Conversation
The channel refuses to republish a driver whose artifact bytes moved without a higher version, and #31 moved all eighty: the generated prefix changed for every driver, and forty-three stopped carrying write guards. Gaining a control path is a behaviour change, so those forty-three take a minor. The rest only lost a comment line and take a patch. esphome-dsmr, pixii and sungrow repeat their version inside their own DRIVER table, so those had to move in step with the manifest. Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90af0c8b10
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| name = "ESPHome DSMR (P1)", | ||
| manufacturer = "ESPHome", | ||
| version = "1.0.2", | ||
| version = "1.0.3", |
There was a problem hiding this comment.
When make package-driver ID=esphome-dsmr TARGET=ftw-core runs after this change, it still reads version 1.0.2 from packages/v1/esphome-dsmr/package-source.json while copying source whose DRIVER now reports 1.0.3. This republishes changed bytes under the old package version and creates a package whose payload identity disagrees with its runtime metadata; bump the package recipe to 1.0.3 alongside this line.
AGENTS.md reference: AGENTS.md:L28-L29
Useful? React with 👍 / 👎.
1 participant
Follows #31, whose release run failed on
abb_meter: changed artifact needs a higher version than 1.0.4.The channel refuses to republish a driver whose artifact bytes moved without a higher version, and #31 moved all eighty: the generated prefix changed for every driver, and forty-three stopped carrying write guards.
esphome-dsmr,pixiiandsungrowrepeat their version inside their own DRIVER table, so those moved in step with the manifest — and the esphome Lua harness pins that version, so it moved too.Generated files follow:
index.yaml,devices.yaml,support-status.json,SUPPORT_STATUS.md.make checkclean, 1984 tests.Signed-off-by: Fredrik Ahlgren fredrik@sourceful-labs.com
🤖 Generated with Claude Code