[TEST - do not merge] Prove pull_request_target ignores PR workflow edits#101
[TEST - do not merge] Prove pull_request_target ignores PR workflow edits#101andrewmumblebee wants to merge 1 commit into
Conversation
Throwaway test commit, not meant to merge. Adds an injected step that would print an error and the length of SQUAREDUP_API_KEY if it ran. Opening this branch as a PR against work/ah/fork-pr-runs (which already has pull_request_target configured) should demonstrate that this injected step never executes — proof that a PR can't alter the workflow that runs against it.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Closing — this test doesn't work as designed. GitHub changed pull_request_target (effective 2025-12-08) to always resolve the workflow file from the repo's actual default branch, not the PR's base ref, so this never had a chance to fire against work/ah/fork-pr-runs. See https://github.blog/changelog/2025-11-07-actions-pull_request_target-and-environment-branch-protections-changes/. That's actually a stronger guarantee than what #100 relies on, but it means the new triggers can't be exercised live until they're on main. |
Throwaway test PR, not meant to merge into anything.
Base is
work/ah/fork-pr-runs(which already carries thepull_request_targetchange from #100), head is a branch that adds an injected step topr-run.yamlwhich would print::error::INJECTED STEP RANand the length ofSQUAREDUP_API_KEYif it executed.If #100's claim holds, that step should never appear in this PR's Actions run — only the steps as committed on
work/ah/fork-pr-runsshould execute. Will close this once verified.