๐ ์คํฌ ๋ฌธ์๋ฅผ .claude/skills๋ก ์น๊ฒฉํ๊ณ university-web ๋ฆฌ๋ผ์ดํธ ์ฃผ์์ฌํญ ์คํฌ ์ถ๊ฐ - #611
๐ ์คํฌ ๋ฌธ์๋ฅผ .claude/skills๋ก ์น๊ฒฉํ๊ณ university-web ๋ฆฌ๋ผ์ดํธ ์ฃผ์์ฌํญ ์คํฌ ์ถ๊ฐ#611manNomi wants to merge 3 commits into
Conversation
- docs/skills/*.md๋ฅผ ์คํ ๊ฐ๋ฅํ .claude/skills/*/SKILL.md ํ์(frontmatter ํฌํจ)์ผ๋ก ์ด๊ด - apps/university-web๊ฐ ๋ณ๋ ๋ฐฐํฌ๋๋ Multi-Zone SSG ์ฑ์ด๋ฉฐ ํ์ฌ ๋ ์ด์์ ๋ฆฌ๋ผ์ดํธ๊ฐ ์งํ ์ค์์ ๋ช ์ํ๋ university-web-rewrite-caution ์คํฌ ์ ์ค - CLAUDE.md์ ๋๋ฝ๋์ด ์๋ ํ๋ก์ ํธ ๊ฐ์ ์ถ๊ฐ (๊ธฐ์กด์ ์ปค๋ฐ ๊ท์น๋ง ์กด์ฌ) - AGENTS.md/llms.txt์์ ์ ์คํฌ ๊ฒฝ๋ก์ university-web ์ฃผ์์ฌํญ์ ์ฐธ์กฐํ๋๋ก ๊ฐฑ์
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Walkthrough
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: ๐ฅ Pre-merge checks | โ 5โ Passed checks (5 passed)
โจ Finishing Touches๐ Generate docstrings
๐งช Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
๐ก Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4dd3f320ea
โน๏ธ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with ๐.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| university ๊ด๋ จ worktree/๋ธ๋์น๊ฐ ์ด๋ฏธ ๋ ์๋ค๋ฉด(์: `feat/skyscanner-layout-poc`, `fix/university-*`), ๊ฐ์ ํ๋ฉด์ ๊ฑด๋๋ฆฌ๊ธฐ ์ ์ ํด๋น ๋ธ๋์น์ ์ต์ diff๋ฅผ ํ์ธํด ์ค๋ณต ์์ ์ ํผํ๋ค. | ||
|
|
||
| 2. **`docs/screenshots/`์ ์ด๋ฏธ ์๋ POC ์๋ฃ๋ฅผ ํ์ธํ๋ค.** | ||
| - `docs/screenshots/skyscanner-layout-poc/`, `docs/screenshots/university-skyscanner-layout-poc/`์ ๋ฐ์คํฌํฑ(1440x1000)/๋ชจ๋ฐ์ผ(390x844) contact sheet๊ฐ ์๋ค. |
There was a problem hiding this comment.
Add the POC artifacts required by this checklist
When an agent follows this mandatory university-web checklist, neither referenced POC directory exists in the reviewed tree; a repo-wide inspection of docs/screenshots finds only gradient-before.png and gradient-after.png. The agent therefore cannot inspect the claimed visual baseline or the README referenced later in the skill, so commit those artifacts or replace these references with paths that actually exist.
AGENTS.md reference: AGENTS.md:L62-L62
Useful? React with ๐ย / ๐.
- ํ๋ก์ ํธ ๊ฐ์/์ปค๋ฐ ์ปจ๋ฒค์ /์คํฌ ๋ชฉ๋ก์ AGENTS.md ํ๋๋ก ๋ชจ์ Codex๊ฐ ๊ทธ๋๋ก ์ฝ๊ณ Claude Code๋ @AGENTS.md import๋ก ๋์ผ ๋ด์ฉ์ ๊ฐ์ ธ์ค๋๋ก ๋ณ๊ฒฝ (์ค๋ณต/๋๋ฆฌํํธ ์ ๊ฑฐ) - CLAUDE.md์ ์๋ชป ์์ฌ ์๋ ๋ฉ๋ชจ๋ฆฌ ์์คํ ์ ์ฉ [[name]] ๋งํฌ ๋ฌธ๋ฒ ์ ๊ฑฐ, ์ผ๋ฐ ํ์ผ ๊ฒฝ๋ก ์ฐธ์กฐ๋ก ๊ต์ฒด - AGENTS.md Skills ํ์ ๊ฐ ์คํฌ์ frontmatter๊ฐ Claude Code ์ ์ฉ ๋ฉํ๋ฐ์ดํฐ์ด๋ฉฐ ๋ค๋ฅธ ์์ด์ ํธ๋ ๋ณธ๋ฌธ๋ง ์ฝ์ผ๋ฉด ๋๋ค๋ ์๋ด ์ถ๊ฐ
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and canโt be posted inline due to platform limitations.
โ ๏ธ Outside diff range comments (3)
.claude/skills/rebase-issues-405-409/SKILL.md (1)
44-53: ๐ฏ Functional Correctness | ๐ก Minor | โก Quick win1. ์๋ฃ ๊ฒ์ฆ์ ์ปค๋ฐ ๊ฐ์๋ฅผ ๊ณ ์ ํ์ง ๋ง์ธ์.
origin/main์ด ์ ์งํ๊ฑฐ๋ ๋ธ๋์น์ ์ปค๋ฐ์ด ์ถ๊ฐ๋๋ฉด ์ ์์ ์ธ ๋ฆฌ๋ฒ ์ด์ค ๊ฒฐ๊ณผ๋0 8๋ฑ์ผ๋ก ๋ฐ๋ ์ ์์ต๋๋ค. ๊ณ ์ ๊ฐ ๋๋ฌธ์ ์ ํจํ ๋ธ๋์น๋ฅผ ์๋ชป ์คํจ ์ฒ๋ฆฌํ๊ฑฐ๋ ์ปค๋ฐ์ ๋๋ฝํ๋๋ก ์ ๋ํ ์ ์์ผ๋, ์กฐ์ ๊ด๊ณ์ clean ์ํ๋ฅผ ๊ฒ์ฆํ๊ณ ์ปค๋ฐ ์๋ ์ฐธ๊ณ ๊ฐ์ผ๋ก๋ง ์๋ดํด ์ฃผ์ธ์.๐ค Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.claude/skills/rebase-issues-405-409/SKILL.md around lines 44 - 53, Update the โ์๋ฃ ๊ฒ์ฆโ guidance to avoid requiring a fixed `0 7` commit count. Validate that the working tree is clean and the rebased branch has the expected ancestor relationship with `origin/main`; present `git rev-list --left-right --count` only as a reference value, since the count may legitimately change..claude/skills/univ-extends-bruno-sync/SKILL.md (2)
48-51: ๐ฏ Functional Correctness | ๐ก Minor | โก Quick win2.
BRUNO_COLLECTION_DIR์ฐ์ ์์๋ฅผ ๋ฐ์ํด ์คํจ ์กฐ๊ฑด์ ์์ ํ์ธ์.์ค์
packages/api-schema/scripts/sync-bruno.mjs๋BRUNO_COLLECTION_DIR์ด ์ค์ ๋๋ฉดBRUNO_SOURCE_MODE๋ณด๋ค ๋จผ์ ํด๋น ๋ก์ปฌ ๊ฒฝ๋ก๋ฅผ ์ฌ์ฉํฉ๋๋ค. ๋ฐ๋ผ์BRUNO_SOURCE_MODE=remote์ฌ๋ ์ ํจํBRUNO_COLLECTION_DIR์ด ์์ผ๋ฉดBRUNO_REPO_URL์์ด ๋์ํ ์ ์์ต๋๋ค.โremote ๋ชจ๋์์ ํญ์ URL์ด ํ์ํ๋คโ๊ฐ ์๋๋ผ, ๋ช ์์ collection directory๊ฐ ์๊ณ ์๊ฒฉ ๊ฒฝ๋ก๋ฅผ resolveํด์ผ ํ ๋ URL์ด ํ์ํ๋ค๊ณ ๋ฌธ์ํํด์ผ ํฉ๋๋ค.
๐ค Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.claude/skills/univ-extends-bruno-sync/SKILL.md around lines 48 - 51, ์คํจ ๋์ ์น์ ์ BRUNO_REPO_URL ์กฐ๊ฑด์ ์์ ํด BRUNO_COLLECTION_DIR์ด ์ ํจํ๊ฒ ์ค์ ๋ ๊ฒฝ์ฐ์๋ BRUNO_SOURCE_MODE=remote์ฌ๋ URL ์์ด ๋์ํ ์ ์์์ ๋ฐ์ํ์ธ์. ๋ช ์์ collection directory๊ฐ ์์ด์ ์๊ฒฉ ๊ฒฝ๋ก๋ฅผ resolveํด์ผ ํ๋ ๊ฒฝ์ฐ์๋ง BRUNO_REPO_URL ๋ฏธ์ค์ ์ผ๋ก ์ฆ์ ์คํจํ๋ค๊ณ ๋ฌธ์ํํ๊ณ , ๊ด๋ จ๋ BRUNO_COLLECTION_PATH ์กฐ๊ฑด์ ๊ธฐ์กด ๋์์ ๋ง๊ฒ ์ ์งํ์ธ์.
15-20: ๐๏ธ Data Integrity & Integration | ๐ Major | โก Quick win1.
develop๊ธฐ์ค ๋ธ๋์น๋ฅผ ์ค์ ๋ก ์ต์ ํํ๋ ๋ช ๋ น์ ๋ช ์ํ์ธ์.ํ์ฌ ์ ์ฐจ๋
git fetch --all --pruneํ ๋ก์ปฌdevelop์ ๋ฐ๋ก ๋ฆฌ๋ฒ ์ด์ค ๊ธฐ์ค์ผ๋ก ์ฌ์ฉํ์ง๋ง, ๊ธฐ์กด ๋ก์ปฌdevelop์ด stale์ด์ด๋ ๊ฐฑ์ ํ์ง ์์ต๋๋ค.develop์ด ์์ ๋ ์์ฑํ๋ ์ ์ฐจ๋ ์์ดgit rebase develop์ด ์คํจํ ์ ์์ต๋๋ค.
origin/develop์ ์ฌ์ฉํ ์ง,origin/main์ ์ฌ์ฉํ ์ง ๋ช ํํ ์ ํ ๋ค ํด๋น ๊ธฐ์ค์ ์ง์ checkout/resetํ๊ฑฐ๋git rebase origin/main์ฒ๋ผ ๋ช ์ํด ์ฃผ์ธ์.๐ค Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.claude/skills/univ-extends-bruno-sync/SKILL.md around lines 15 - 20, Update the rebase instructions around the `develop` branch to explicitly select and refresh the intended upstream base, including creating or resetting local `develop` when absent or stale. Use a direct command referencing the chosen remote branch (`origin/develop` or `origin/main`), then ensure the final `git rebase develop` operates on that updated base.
๐ค Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/skills/biome-unification-ci/SKILL.md:
- Around line 64-66: ๊ฒ์ฆ ์ฒดํฌ๋ฆฌ์คํธ์ ์ ์ฅ์ ๋ฃจํธ ํ์
๊ฒ์ฌ๋ฅผ ์ํ ๋ณ๋ `pnpm typecheck` ํญ๋ชฉ์ ์ถ๊ฐํ์ธ์.
๊ธฐ์กด `pnpm ci:check`์ `pnpm build` ๋ฐ ๊ด๋ จ ์ฑ ๊ฒ์ฌ ํญ๋ชฉ์ ์ ์งํด ํธ์ ์ ํ์ ๊ฒ์ฆ ์ ์ฐจ๊ฐ ๋ชจ๋ ๋ช
์๋๋๋ก ํ์ธ์.
In @.claude/skills/commit-push-pr/SKILL.md:
- Line 23: ์ปค๋ฐ ์์๋ฅผ ์ ์ฅ์ ๊ท์น๊ณผ ์ผ์นํ๋๋ก ์์ ํ์ธ์. SKILL.md์ ํด๋น ์คํ ์์์์ `docs: ...` ์์ ๋ฌธ์
์ปค๋ฐ์ฉ ์ด๋ชจ์ง ์ ๋์ฌ๋ฅผ ์ถ๊ฐํ๊ณ , ๊ธฐ์กด ์ปค๋ฐ ํ์
๊ณผ ์ ๋ชฉ ๋ด์ฉ์ ์ ์งํ์ธ์.
---
Outside diff comments:
In @.claude/skills/rebase-issues-405-409/SKILL.md:
- Around line 44-53: Update the โ์๋ฃ ๊ฒ์ฆโ guidance to avoid requiring a fixed `0
7` commit count. Validate that the working tree is clean and the rebased branch
has the expected ancestor relationship with `origin/main`; present `git rev-list
--left-right --count` only as a reference value, since the count may
legitimately change.
In @.claude/skills/univ-extends-bruno-sync/SKILL.md:
- Around line 48-51: ์คํจ ๋์ ์น์
์ BRUNO_REPO_URL ์กฐ๊ฑด์ ์์ ํด BRUNO_COLLECTION_DIR์ด ์ ํจํ๊ฒ
์ค์ ๋ ๊ฒฝ์ฐ์๋ BRUNO_SOURCE_MODE=remote์ฌ๋ URL ์์ด ๋์ํ ์ ์์์ ๋ฐ์ํ์ธ์. ๋ช
์์ collection
directory๊ฐ ์์ด์ ์๊ฒฉ ๊ฒฝ๋ก๋ฅผ resolveํด์ผ ํ๋ ๊ฒฝ์ฐ์๋ง BRUNO_REPO_URL ๋ฏธ์ค์ ์ผ๋ก ์ฆ์ ์คํจํ๋ค๊ณ ๋ฌธ์ํํ๊ณ , ๊ด๋ จ๋
BRUNO_COLLECTION_PATH ์กฐ๊ฑด์ ๊ธฐ์กด ๋์์ ๋ง๊ฒ ์ ์งํ์ธ์.
- Around line 15-20: Update the rebase instructions around the `develop` branch
to explicitly select and refresh the intended upstream base, including creating
or resetting local `develop` when absent or stale. Use a direct command
referencing the chosen remote branch (`origin/develop` or `origin/main`), then
ensure the final `git rebase develop` operates on that updated base.
๐ช Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
โน๏ธ Review info
โ๏ธ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e58f68d9-666c-4df6-a997-74850fff652b
๐ Files selected for processing (9)
.claude/skills/biome-unification-ci/SKILL.md.claude/skills/bruno-codegen-react-query/SKILL.md.claude/skills/commit-push-pr/SKILL.md.claude/skills/rebase-issues-405-409/SKILL.md.claude/skills/univ-extends-bruno-sync/SKILL.md.claude/skills/university-web-rewrite-caution/SKILL.mdAGENTS.mdCLAUDE.mdllms.txt
- univ-extends-bruno-sync: sync-bruno.mjs ์ค์ ์ฐ์ ์์๋๋ก BRUNO_COLLECTION_DIR์ด BRUNO_SOURCE_MODE๋ณด๋ค ์ฐ์ ํ๋ค๋ ์ ์ ๋ฐ์ํ๊ณ , ์กด์ฌํ์ง ์๋ develop ๋ธ๋์น๋ฅผ ์์๋ก ๋ง๋ค์ง ์๊ณ origin/develop ์กด์ฌ ์ฌ๋ถ๋ฅผ ๋จผ์ ํ์ธํ๋๋ก ๋ฆฌ๋ฒ ์ด์ค ์ ์ฐจ ์์ - rebase-issues-405-409: ์๋ฃ ๊ฒ์ฆ์์ ํ๋์ฝ๋ฉ๋ ์ปค๋ฐ ๊ฐ์(0 7) ๊ธฐ๋๊ฐ์ ์ ๊ฑฐํ๊ณ ์กฐ์ ๊ด๊ณ + clean ์ํ ๊ธฐ์ค์ผ๋ก ๊ฒ์ฆํ๋๋ก ์์ - biome-unification-ci: ๊ฒ์ฆ ์ฒดํฌ๋ฆฌ์คํธ์ ๋๋ฝ๋์ด ์๋ ๋ฃจํธ pnpm typecheck ์ถ๊ฐ - commit-push-pr: ์คํ ์์ ์ปค๋ฐ ๋ฉ์์ง์ ์ ์ฅ์ ๊ท์น(์ด๋ชจ์ง ์ ๋์ฌ) ๋ฐ์, CLAUDE.md ๋์ AGENTS.md๋ฅผ ์ฐธ์กฐํ๋๋ก ์์
There was a problem hiding this comment.
Actionable comments posted: 4
๐ค Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/skills/commit-push-pr/SKILL.md:
- Around line 26-31: Update the Execution Steps in the commit-push-PR skill
documentation to run pnpm typecheck and the relevant checks for changed
applications before git add. Keep the existing commit and push commands
unchanged, and explicitly require these validations before proceeding with the
push.
In @.claude/skills/univ-extends-bruno-sync/SKILL.md:
- Line 19: Update the develop-branch synchronization instructions in the rebase
workflow to remove the destructive git reset --hard behavior. Require a clean
working tree and a backup before any potentially destructive operation, or
replace it with a safe fast-forward-only update such as git pull --ff-only
origin develop while preserving the existing branch-creation path.
- Around line 18-23: ๋ฆฌ๋ฒ ์ด์ค ์คํ ์ ์ ํ์ฌ ์์
๋ธ๋์น๋ก ๋ณต๊ทํ๋ ๋จ๊ณ๋ฅผ ์ถ๊ฐํ์ธ์. `develop` ๋๊ธฐํ ๊ณผ์ ์์
๋ธ๋์น๋ฅผ ์ ํํ๋ ํ๋ฆ์ ์์ ํด `git rebase develop` ๋๋ `git rebase origin/main`์ด ์์
๋ธ๋์น์์
์คํ๋๋๋ก ํ๋ฉฐ, `feat/univ-extends` ๊ฐ์ ํ์ฌ ๋ธ๋์น๊ฐ `develop` ์์ฒด๋ฅผ ๋ฆฌ๋ฒ ์ด์คํ๋ no-op์ด ๋์ง ์๊ฒ ํ์ธ์.
In `@AGENTS.md`:
- Around line 41-42: AGENTS.md์ ์ปค๋ฐ ๋ฉ์์ง ๋ฐ PR ์ ๋ชฉ/๋ณธ๋ฌธ ์์ฑ ๊ท์น์์ โ๊ธฐ๋ณธ์ ์ผ๋กโ๋ผ๋ ์์ธ ํํ์ ์ ๊ฑฐํ๊ณ ,
ํด๋น ๋ฌธ์ฅ์ ๋ฐ๋์ ํ๊ตญ์ด๋ก ์์ฑํ๋๋ก ํต์ผํ์ธ์. ๊ธฐ์กด ๊ท์น๊ณผ ์ค๋ณต๋๋ฉด ํ ๊ณณ๋ง ๋จ๊ฒจ ๊ท์น ๊ฐ ์ถฉ๋์ด ์๋๋ก ์ ๋ฆฌํ์ธ์.
๐ช Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
โน๏ธ Review info
โ๏ธ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: bfe0745f-9a73-4272-832f-b744a0d49253
๐ Files selected for processing (7)
.claude/skills/biome-unification-ci/SKILL.md.claude/skills/commit-push-pr/SKILL.md.claude/skills/rebase-issues-405-409/SKILL.md.claude/skills/univ-extends-bruno-sync/SKILL.md.claude/skills/university-web-rewrite-caution/SKILL.mdAGENTS.mdCLAUDE.md
๐ง Files skipped from review as they are similar to previous changes (2)
- .claude/skills/biome-unification-ci/SKILL.md
- .claude/skills/rebase-issues-405-409/SKILL.md
| ## Execution Steps | ||
|
|
||
| ```bash | ||
| git add <files> | ||
| git commit -m "docs: ์ปค๋ฐ/ํธ์/PR ์๋ธ์์ด์ ํธ ์คํฌ ๋ฌธ์ ์ถ๊ฐ" | ||
| git commit -m "๐ docs: ์ปค๋ฐ/ํธ์/PR ์๋ธ์์ด์ ํธ ์คํฌ ๋ฌธ์ ์ถ๊ฐ" | ||
| git push -u origin <branch> |
There was a problem hiding this comment.
๐ Maintainability & Code Quality | ๐ Major | โก Quick win
1. ํธ์ ์ ํ์ ๊ฒ์ฌ๋ฅผ ์คํํ๋๋ก ์ ์ฐจ๋ฅผ ๋ณด๊ฐํด ์ฃผ์ธ์.
ํ์ฌ ์คํ ๋จ๊ณ์๋ ๋ธ๋์นยท์ํ ํ์ธ๊ณผ ์ปค๋ฐ/ํธ์๋ง ์๊ณ , pnpm typecheck ๋ฐ ๋ณ๊ฒฝ๋ ์ฑ์ ๊ด๋ จ ๊ฒ์ฌ๊ฐ ์์ต๋๋ค. ์ด ์คํฌ์ ๋ฐ๋ฅด๋ ์์ด์ ํธ๊ฐ ๊ฒ์ฆ ์์ด ํธ์ํ์ง ์๋๋ก git add ์ ์ ํด๋น ๊ฒ์ฌ ๋จ๊ณ๋ฅผ ๋ช
์ํด ์ฃผ์ธ์.
As per coding guidelines, ํธ์ ์ ์ pnpm typecheck์ ๊ด๋ จ ์ฑ ๊ฒ์ฌ๋ฅผ ์คํํด์ผ ํฉ๋๋ค.
์ ์๋ ์์
## Execution Steps+pnpm typecheck
+# ๋ณ๊ฒฝ๋ ์ฑ์ ๊ด๋ จ ๊ฒ์ฌ ์คํ
+
git add
</details>
<details>
<summary>๐ค Prompt for AI Agents</summary>
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.claude/skills/commit-push-pr/SKILL.md around lines 26 - 31, Update the
Execution Steps in the commit-push-PR skill documentation to run pnpm typecheck
and the relevant checks for changed applications before git add. Keep the
existing commit and push commands unchanged, and explicitly require these
validations before proceeding with the push.
</details>
<!-- fingerprinting:phantom:triton:luna -->
<!-- cr-indicator-types:potential_issue -->
<!-- cr-comment:v1:c8134dfb3512db3894ef8eef -->
_Source: Coding guidelines_
<!-- This is an auto-generated comment by CodeRabbit -->
| - `git ls-remote --heads origin develop`์ผ๋ก ์๊ฒฉ `develop` ์กด์ฌ ์ฌ๋ถ๋ฅผ ๋จผ์ ํ์ธํ๋ค. | ||
| - ์กด์ฌํ๋ฉด: ๋ก์ปฌ `develop`์ ์ต์ `origin/develop`์ผ๋ก ๋ง์ถ ๋ค(`git checkout develop && git reset --hard origin/develop`, ๋ก์ปฌ์ ์์ผ๋ฉด `git checkout -b develop origin/develop`) ๊ทธ ๋ธ๋์น๋ก ๋ฆฌ๋ฒ ์ด์คํ๋ค. | ||
| - ์กด์ฌํ์ง ์์ผ๋ฉด(์ด ์ ์ฅ์๋ ๊ธฐ๋ณธ์ ์ผ๋ก `develop`์ด ์๋ค): `origin/main`์ ๊ธฐ์ค์ผ๋ก ์ง์ ๋ฆฌ๋ฒ ์ด์คํ๋ค. ๋ก์ปฌ `develop`์ ๋ง๋ค์ด์ ์ฐํํ์ง ์๋๋ค. | ||
| 3. ๋ฆฌ๋ฒ ์ด์ค ์คํ | ||
| - `origin/develop`์ด ์๋ ๊ฒฝ์ฐ: `git rebase develop` | ||
| - ์๋ ๊ฒฝ์ฐ: `git rebase origin/main` |
There was a problem hiding this comment.
๐ฏ Functional Correctness | ๐ Major | โก Quick win
1. ๋ฆฌ๋ฒ ์ด์ค ์ ์ ์์ ๋ธ๋์น๋ก ๋์์ค๋ ๋จ๊ณ๋ฅผ ์ถ๊ฐํด์ผ ํฉ๋๋ค.
Line 19์์ develop์ผ๋ก ์ ํํ ๋ค Line 22์์ ๋ฐ๋ก git rebase develop์ ์คํํ๋ฏ๋ก, ํ์ฌ ๋ธ๋์น๊ฐ develop์ธ ์ํ์์ ์๊ธฐ ์์ ์ ๋ฆฌ๋ฒ ์ด์คํ๋ no-op์ด ๋ฉ๋๋ค. ๊ฒฐ๊ณผ์ ์ผ๋ก feat/univ-extends๋ ๋ฆฌ๋ฒ ์ด์ค๋์ง ์์ต๋๋ค.
์์ ์์
- ์กด์ฌํ๋ฉด: ๋ก์ปฌ `develop`์ ์ต์ `origin/develop`์ผ๋ก ๋ง์ถ๋ค.
+ - ๋๊ธฐํ๊ฐ ๋๋๋ฉด `git checkout feat/univ-extends`๋ก ์์
๋ธ๋์น๋ก ๋์๊ฐ๋ค.
- `origin/develop`์ด ์๋ ๊ฒฝ์ฐ: `git rebase develop`๐ Committable suggestion
โผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - `git ls-remote --heads origin develop`์ผ๋ก ์๊ฒฉ `develop` ์กด์ฌ ์ฌ๋ถ๋ฅผ ๋จผ์ ํ์ธํ๋ค. | |
| - ์กด์ฌํ๋ฉด: ๋ก์ปฌ `develop`์ ์ต์ `origin/develop`์ผ๋ก ๋ง์ถ ๋ค(`git checkout develop && git reset --hard origin/develop`, ๋ก์ปฌ์ ์์ผ๋ฉด `git checkout -b develop origin/develop`) ๊ทธ ๋ธ๋์น๋ก ๋ฆฌ๋ฒ ์ด์คํ๋ค. | |
| - ์กด์ฌํ์ง ์์ผ๋ฉด(์ด ์ ์ฅ์๋ ๊ธฐ๋ณธ์ ์ผ๋ก `develop`์ด ์๋ค): `origin/main`์ ๊ธฐ์ค์ผ๋ก ์ง์ ๋ฆฌ๋ฒ ์ด์คํ๋ค. ๋ก์ปฌ `develop`์ ๋ง๋ค์ด์ ์ฐํํ์ง ์๋๋ค. | |
| 3. ๋ฆฌ๋ฒ ์ด์ค ์คํ | |
| - `origin/develop`์ด ์๋ ๊ฒฝ์ฐ: `git rebase develop` | |
| - ์๋ ๊ฒฝ์ฐ: `git rebase origin/main` | |
| - `git ls-remote --heads origin develop`์ผ๋ก ์๊ฒฉ `develop` ์กด์ฌ ์ฌ๋ถ๋ฅผ ๋จผ์ ํ์ธํ๋ค. | |
| - ์กด์ฌํ๋ฉด: ๋ก์ปฌ `develop`์ ์ต์ `origin/develop`์ผ๋ก ๋ง์ถ ๋ค(`git checkout develop && git reset --hard origin/develop`, ๋ก์ปฌ์ ์์ผ๋ฉด `git checkout -b develop origin/develop`) ๋๊ธฐํ๊ฐ ๋๋๋ฉด `git checkout feat/univ-extends`๋ก ์์ ๋ธ๋์น๋ก ๋์๊ฐ๋ค. | |
| - ์กด์ฌํ์ง ์์ผ๋ฉด(์ด ์ ์ฅ์๋ ๊ธฐ๋ณธ์ ์ผ๋ก `develop`์ด ์๋ค): `origin/main`์ ๊ธฐ์ค์ผ๋ก ์ง์ ๋ฆฌ๋ฒ ์ด์คํ๋ค. ๋ก์ปฌ `develop`์ ๋ง๋ค์ด์ ์ฐํํ์ง ์๋๋ค. | |
| 3. ๋ฆฌ๋ฒ ์ด์ค ์คํ | |
| - `origin/develop`์ด ์๋ ๊ฒฝ์ฐ: `git rebase develop` | |
| - ์๋ ๊ฒฝ์ฐ: `git rebase origin/main` |
๐งฐ Tools
๐ช SkillSpector (2.3.11)
[error] 19: [TM1] Tool Parameter Abuse: Tool parameters are crafted to achieve unintended or unsafe behavior. Parameter abuse can bypass intended safety checks (e.g. shell=True, --force, dangerous glob patterns).
Remediation: Validate all tool parameters against an allowlist. Reject dangerous parameter values (shell=True, --force, -rf /) and use safe defaults.
(Tool Misuse (TM1))
๐ค Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.claude/skills/univ-extends-bruno-sync/SKILL.md around lines 18 - 23, ๋ฆฌ๋ฒ ์ด์ค
์คํ ์ ์ ํ์ฌ ์์
๋ธ๋์น๋ก ๋ณต๊ทํ๋ ๋จ๊ณ๋ฅผ ์ถ๊ฐํ์ธ์. `develop` ๋๊ธฐํ ๊ณผ์ ์์ ๋ธ๋์น๋ฅผ ์ ํํ๋ ํ๋ฆ์ ์์ ํด `git
rebase develop` ๋๋ `git rebase origin/main`์ด ์์
๋ธ๋์น์์ ์คํ๋๋๋ก ํ๋ฉฐ,
`feat/univ-extends` ๊ฐ์ ํ์ฌ ๋ธ๋์น๊ฐ `develop` ์์ฒด๋ฅผ ๋ฆฌ๋ฒ ์ด์คํ๋ no-op์ด ๋์ง ์๊ฒ ํ์ธ์.
| - `git fetch --all --prune` | ||
| 2. ๊ธฐ์ค ๋ธ๋์น ํ์ธ | ||
| - `git ls-remote --heads origin develop`์ผ๋ก ์๊ฒฉ `develop` ์กด์ฌ ์ฌ๋ถ๋ฅผ ๋จผ์ ํ์ธํ๋ค. | ||
| - ์กด์ฌํ๋ฉด: ๋ก์ปฌ `develop`์ ์ต์ `origin/develop`์ผ๋ก ๋ง์ถ ๋ค(`git checkout develop && git reset --hard origin/develop`, ๋ก์ปฌ์ ์์ผ๋ฉด `git checkout -b develop origin/develop`) ๊ทธ ๋ธ๋์น๋ก ๋ฆฌ๋ฒ ์ด์คํ๋ค. |
There was a problem hiding this comment.
๐๏ธ Data Integrity & Integration | ๐ Major | โก Quick win
2. git reset --hard๋ก ๋ก์ปฌ ์์
์ ์ญ์ ํ์ง ์๋๋ก ์์ ์ฅ์น๋ฅผ ์ถ๊ฐํด์ผ ํฉ๋๋ค.
Line 19์ ๋ช
๋ น์ ์ถ์ ์ค์ธ ๋ฏธ์ปค๋ฐ ๋ณ๊ฒฝ์ฌํญ๋ฟ ์๋๋ผ ์๊ฒฉ์ ์๋ ๋ก์ปฌ develop ์ปค๋ฐ๋ ์ฐธ์กฐ์์ ์ ๊ฑฐํ ์ ์์ต๋๋ค. ๋จผ์ ๊นจ๋ํ ์์
ํธ๋ฆฌ์ ๋ฐฑ์
์ ์๊ตฌํ๊ฑฐ๋, ๊ธฐ๋ณธ ๋์์ git pull --ff-only origin develop์ฒ๋ผ ์์ ํ๊ฒ ์คํจํ๋ ๋ฐฉ์์ผ๋ก ๋ฐ๊ฟ ์ฃผ์ธ์.
๐งฐ Tools
๐ช SkillSpector (2.3.11)
[error] 19: [TM1] Tool Parameter Abuse: Tool parameters are crafted to achieve unintended or unsafe behavior. Parameter abuse can bypass intended safety checks (e.g. shell=True, --force, dangerous glob patterns).
Remediation: Validate all tool parameters against an allowlist. Reject dangerous parameter values (shell=True, --force, -rf /) and use safe defaults.
(Tool Misuse (TM1))
๐ค Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.claude/skills/univ-extends-bruno-sync/SKILL.md at line 19, Update the
develop-branch synchronization instructions in the rebase workflow to remove the
destructive git reset --hard behavior. Require a clean working tree and a backup
before any potentially destructive operation, or replace it with a safe
fast-forward-only update such as git pull --ff-only origin develop while
preserving the existing branch-creation path.
Source: Linters/SAST tools
| - Keep commit messages aligned with the Commit Message Convention below. | ||
| - Write commit messages and PR title/body in Korean by default. |
There was a problem hiding this comment.
๐ Maintainability & Code Quality | ๐ก Minor | โก Quick win
1. ํ๊ตญ์ด ์์ฑ ๊ท์น์ โ๋ฐ๋์โ๋ก ํต์ผํ์ธ์.
Line 8์์๋ ์ปค๋ฐ ๋ฉ์์ง์ PR ์ ๋ชฉ/๋ณธ๋ฌธ์ ๋ฐ๋์ ํ๊ตญ์ด๋ก ์์ฑํ๋๋ก ๊ท์ ํ์ง๋ง, ์ด ๊ตฌ๊ฐ์ โ๊ธฐ๋ณธ์ ์ผ๋กโ๋ผ๊ณ ํํํด ์์ธ๋ฅผ ํ์ฉํ๋ ๊ฒ์ฒ๋ผ ๋ณด์
๋๋ค. ๋ ๊ท์น์ด ์ถฉ๋ํ์ง ์๋๋ก ํด๋น ๋ฌธ์ฅ์ ์ปค๋ฐ ๋ฉ์์ง์ PR ์ ๋ชฉ/๋ณธ๋ฌธ์ ๋ฐ๋์ ํ๊ตญ์ด๋ก ์์ฑํ๋ค.๋ก ์์ ํ๊ฑฐ๋ ์ค๋ณต ๋ฌธ์ฅ์ ์ ๊ฑฐํด ์ฃผ์ธ์.
As per coding guidelines, ์ปค๋ฐ ๋ฉ์์ง์ PR ์ ๋ชฉ/๋ณธ๋ฌธ์ ๋ฐ๋์ ํ๊ตญ์ด๋ก ์์ฑํด์ผ ํฉ๋๋ค.
์์ ์์
- - Write commit messages and PR title/body in Korean by default.
+ - Write commit messages and PR title/body in Korean.๐ Committable suggestion
โผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - Keep commit messages aligned with the Commit Message Convention below. | |
| - Write commit messages and PR title/body in Korean by default. | |
| - Keep commit messages aligned with the Commit Message Convention below. | |
| - Write commit messages and PR title/body in Korean. |
๐ค Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@AGENTS.md` around lines 41 - 42, AGENTS.md์ ์ปค๋ฐ ๋ฉ์์ง ๋ฐ PR ์ ๋ชฉ/๋ณธ๋ฌธ ์์ฑ ๊ท์น์์
โ๊ธฐ๋ณธ์ ์ผ๋กโ๋ผ๋ ์์ธ ํํ์ ์ ๊ฑฐํ๊ณ , ํด๋น ๋ฌธ์ฅ์ ๋ฐ๋์ ํ๊ตญ์ด๋ก ์์ฑํ๋๋ก ํต์ผํ์ธ์. ๊ธฐ์กด ๊ท์น๊ณผ ์ค๋ณต๋๋ฉด ํ ๊ณณ๋ง ๋จ๊ฒจ ๊ท์น ๊ฐ ์ถฉ๋์ด
์๋๋ก ์ ๋ฆฌํ์ธ์.
Source: Coding guidelines
๊ด๋ จ ์ด์
์์ ๋ด์ฉ
docs/skills/*.md(๋ฐ๋ถ ํ ์คํธ ๋ฌธ์)๋ฅผ.claude/skills/*/SKILL.md(YAML frontmatter ํฌํจ)๋ก ์ด๊ดํด Claude Code Skill ๋๊ตฌ๊ฐ ์๋ ํ์งยทํธ์ถํ ์ ์๋๋ก ์น๊ฒฉํ์ต๋๋ค.apps/university-web๊ฐ ๋ณ๋ ๋ฐฐํฌ๋๋ Next.js Multi-Zone SSG ์ฑ์ด๋ฉฐ ํ์ฌ ๋ฐ์คํฌํฑ ๋ ์ด์์ ๋ฆฌ๋ผ์ดํธ๊ฐ ์งํ ์ค์์ ๋ช ์ํ๋university-web-rewrite-caution์คํฌ์ ์ ์คํ์ต๋๋ค. ์งํ ์ค์ธ worktree/๋ธ๋์น ํ์ธ, ๋ผ์ฐํธ ์์ ๊ถ ๊ฒฝ๊ณ,AUTHENTICATION.md/COMPONENTS.md์ค๋ณต ๋๊ธฐํ, SSG ๋น๋ ์คํจ ์ค๊ณ ์ ์ง ๋ฑ์ ์ฒดํฌ๋ฆฌ์คํธํํ์ต๋๋ค.AGENTS.md๋ฅผ ๋จ์ผ ์์ค๋ก ํตํฉํ์ต๋๋ค. ํ๋ก์ ํธ ๊ฐ์ยท์ปค๋ฐ ์ปจ๋ฒค์ ยท์คํฌ ๋ชฉ๋ก์ ๋ชจ๋AGENTS.md์ ๋๊ณ ,CLAUDE.md๋@AGENTS.mdimport๋ก ๋์ผ ๋ด์ฉ์ ๊ฐ์ ธ์ค๋ ์์ ํ์ผ๋ก ์ ๋ฆฌํ์ต๋๋ค.[[name]]๋งํฌ ๋ฌธ๋ฒ์ ์ ๊ฑฐํ๊ณ ์ผ๋ฐ ํ์ผ ๊ฒฝ๋ก ์ฐธ์กฐ๋ก ๊ต์ฒดํ์ต๋๋ค.packages/api-schema/scripts/sync-bruno.mjs)๋ฅผ ๋์กฐํด ๊ฒ์ฆํ ๋ค 4๊ฑด ๋ชจ๋ ์์ ํ์ต๋๋ค.univ-extends-bruno-sync:BRUNO_COLLECTION_DIR์ดBRUNO_SOURCE_MODE๋ณด๋ค ์ฐ์ ์ ์ฉ๋๋ ์ค์ ๋์์ ๋ฐ์, ์กด์ฌํ์ง ์๋develop๋ธ๋์น๋ฅผ ์์๋ก ๋ง๋ค์ง ์๋๋ก ๋ฆฌ๋ฒ ์ด์ค ์ ์ฐจ ์์ rebase-issues-405-409: ์๋ฃ ๊ฒ์ฆ์์ ํ๋์ฝ๋ฉ๋ ์ปค๋ฐ ๊ฐ์(0 7) ๊ธฐ๋๊ฐ ์ ๊ฑฐ, ์กฐ์ ๊ด๊ณ + clean ์ํ ๊ธฐ์ค์ผ๋ก ๋ณ๊ฒฝbiome-unification-ci: ๊ฒ์ฆ ์ฒดํฌ๋ฆฌ์คํธ์ ๋๋ฝ๋ ๋ฃจํธpnpm typecheck์ถ๊ฐcommit-push-pr: ์คํ ์์ ์ปค๋ฐ ๋ฉ์์ง์ ์ ์ฅ์ ์ด๋ชจ์ง ์ปจ๋ฒค์ ๋ฐ์ํน์ด ์ฌํญ
.claude/skills/university-web-rewrite-caution/SKILL.md์ ์ค์ ์งํ ์ค์ธ ๋ฆฌ๋ผ์ดํธ ์ํฉ(๋ธ๋์น/์ํฌํธ๋ฆฌ)์ด ์๊ฐ์ด ์ง๋๋ฉด ๋ฐ๋ ์ ์์ผ๋, ๋ณํฉ ํ ์ค์ ์ํฉ๊ณผ ๊ณ์ ๋ง๋์ง ์ฃผ๊ธฐ์ ์ผ๋ก ํ์ธ์ด ํ์ํฉ๋๋ค.๋ฆฌ๋ทฐ ์๊ตฌ์ฌํญ (์ ํ)
.claude/skills/university-web-rewrite-caution/SKILL.md๋ด์ฉ์ด ์ค์ university-web ๋ฆฌ๋ผ์ดํธ ์์ ์ํฉ๊ณผ ๋ง๋์ง ํ์ธ ๋ถํ๋๋ฆฝ๋๋ค.