[C extension parser] Disable function outlining on Clang#1055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with commit
cc010c46889c8516a9a357336b262ce35779985fsome of the generated instructions in the C extension parser started getting outlined into function calls when compiling with Clang on ARM64. This is most noticeable injson_eat_whitespace_resume_at:Example of one of the outlined functions. They're all small.

Comparing the commit
cc010c46889c8516a9a357336b262ce35779985fwithcc010c46889c8516a9a357336b262ce35779985f:Compiling with
-Rpass=machine-outlinershows the result of the outlining pass:Comparing
masterwith this branch:Note: It might be worthwhile to consider leaving function outlining enabled if Ruby was compiled with
-OsorOzbut I have not attempted to do that.