Skip to content

Improve error handling around job retry with conflict#623

Merged
brandur merged 1 commit into
masterfrom
brandur-unique-conflict-error
Jul 24, 2026
Merged

Improve error handling around job retry with conflict#623
brandur merged 1 commit into
masterfrom
brandur-unique-conflict-error

Conversation

@brandur

@brandur brandur commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Fixes #622, which indicates how when retrying a job and getting a unique
conflict, River UI produces an internal server error instead of a proper
one that's raised to the user.

Fixes #622, which indicates how when retrying a job and getting a unique
conflict, River UI produces an internal server error instead of a proper
one that's raised to the user.
@brandur
brandur force-pushed the brandur-unique-conflict-error branch from 4a924e6 to 4e4399d Compare July 23, 2026 18:05
@brandur
brandur requested a review from bgentry July 23, 2026 18:07
@brandur

brandur commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator Author

@bgentry Not going to lie, most of this is Codex. I had Codex do another review pass locally and it seems to think the changes are okay.

@bgentry bgentry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, it threw a nice refactor in there too 🤩 There is a ton of low hanging fruit in riverui that modern AIs can absolutely plow through, don't be afraid to go to town shipping anything on it. It's a simple, conventional React app with good foundations and not too much special stuff going on other than the pro/OSS split (but that's really just basic feature detection as far as frontend is concerned).

@brandur

brandur commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator Author

There is a ton of low hanging fruit in riverui that modern AIs can absolutely plow through, don't be afraid to go to town shipping anything on it. It's a simple, conventional React app with good foundations and not too much special stuff going on other than the pro/OSS split (but that's really just basic feature detection as far as frontend is concerned).

Oh yesssss, +1. Totally true — AI could probably make some vast improvements. I'll write that down to try at some point.

@brandur
brandur merged commit 0fb1583 into master Jul 24, 2026
23 checks passed
@brandur
brandur deleted the brandur-unique-conflict-error branch July 24, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Job retry uniqueness conflict replaces the UI with an error screen

2 participants