Skip to content

Preserve multibyte characters when wrapping long source lines#8520

Open
fhammerschmidt wants to merge 2 commits into
masterfrom
fix-rewatch-multichar-emdash-panic
Open

Preserve multibyte characters when wrapping long source lines#8520
fhammerschmidt wants to merge 2 commits into
masterfrom
fix-rewatch-multichar-emdash-panic

Conversation

@fhammerschmidt

Copy link
Copy Markdown
Member

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0720a42e7c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread compiler/ml/code_frame.ml
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.70%. Comparing base (fc2c00f) to head (37fece4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8520   +/-   ##
=======================================
  Coverage   74.70%   74.70%           
=======================================
  Files         458      458           
  Lines       62360    62366    +6     
=======================================
+ Hits        46587    46593    +6     
  Misses      15773    15773           
Files with missing lines Coverage Δ
compiler/ml/code_frame.ml 94.53% <100.00%> (+0.17%) ⬆️
tests/ounit_tests/ounit_utf8_test.ml 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Jul 23, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@8520

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@8520

@rescript/darwin-x64

npm i https://pkg.pr.new/@rescript/darwin-x64@8520

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@8520

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@8520

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@8520

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@8520

commit: 37fece4

@github-actions

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant