feat(a11y): automatic accessible with role prop#57633
Open
mdjastrzebski wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Setting
roleprop (exceptnone/presentation) automatically setsaccessibleprop onViewandImage. This aligns web behavior when settingroleattribute is enough to add the element into accessibility tree.This aligns also with
Imagealtweb-compat prop which also enablesaccessiblewhen set.The change skips
Text,TextInput, etc as they are implicitly members of accessibility tree by default.This change also intentionally skips
accessibilityRoleas legacy, non-web version.This also helps when using React Strict DOM, as it exposes
roleprop, but does not exposeaccessibleprop, hence settingroleonh.divbasically has no effect. I think this changes is better suited for RN repo though.Changelog:
[GENERAL] [CHANGED] Automatically set
acessibleprop whenroleprop is set (exceptnone/presenation)Test Plan:
Added relevant Fantom tests.