Downgrade RCTStatusBarManager error to a warning under VC-based status bar (#57631)#57631
Open
shwanton wants to merge 1 commit into
Open
Downgrade RCTStatusBarManager error to a warning under VC-based status bar (#57631)#57631shwanton wants to merge 1 commit into
shwanton wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@shwanton has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113043635. |
meta-codesync
Bot
changed the title
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Jul 22, 2026
…s bar (react#57631) Summary: `RCTStatusBarManager`'s `setStyle:` and `setHidden:` already no-op when `UIViewControllerBasedStatusBarAppearance` is `YES`. Currently this path emits `RCTLogError`, which redboxes in dev and logs a soft error in release — even though the call is an expected no-op when the view controller owns the status bar. Downgrade to `RCTLogWarn` with a more accurate message so apps adopting VC-based status bar appearance aren't flooded with spurious errors on every `StatusBar.setBarStyle` / `setHidden` call or `<StatusBar>` mount. No behavior change; the methods remain no-ops under the flag. Changelog: [iOS][Changed] - Downgrade RCTStatusBarManager error to a warning when UIViewControllerBasedStatusBarAppearance is YES Differential Revision: D113043635
shwanton
force-pushed
the
export-D113043635
branch
from
July 22, 2026 00:38
5458a57 to
e751359
Compare
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Jul 22, 2026
…s bar (react#57631) Summary: `RCTStatusBarManager`'s `setStyle:` and `setHidden:` already no-op when `UIViewControllerBasedStatusBarAppearance` is `YES`. Currently this path emits `RCTLogError`, which redboxes in dev and logs a soft error in release — even though the call is an expected no-op when the view controller owns the status bar. Downgrade to `RCTLogWarn` with a more accurate message so apps adopting VC-based status bar appearance aren't flooded with spurious errors on every `StatusBar.setBarStyle` / `setHidden` call or `<StatusBar>` mount. No behavior change; the methods remain no-ops under the flag. Changelog: [iOS][Changed] - Downgrade RCTStatusBarManager error to a warning when UIViewControllerBasedStatusBarAppearance is YES Differential Revision: D113043635
shwanton
force-pushed
the
export-D113043635
branch
from
July 22, 2026 00:39
e751359 to
a2d47bc
Compare
…s bar (react#57631) Summary: `RCTStatusBarManager`'s `setStyle:` and `setHidden:` already no-op when `UIViewControllerBasedStatusBarAppearance` is `YES`. Currently this path emits `RCTLogError`, which redboxes in dev and logs a soft error in release — even though the call is an expected no-op when the view controller owns the status bar. Downgrade to `RCTLogWarn` with a more accurate message so apps adopting VC-based status bar appearance aren't flooded with spurious errors on every `StatusBar.setBarStyle` / `setHidden` call or `<StatusBar>` mount. No behavior change; the methods remain no-ops under the flag. Changelog: [iOS][Changed] - Downgrade RCTStatusBarManager error to a warning when UIViewControllerBasedStatusBarAppearance is YES Differential Revision: D113043635
shwanton
force-pushed
the
export-D113043635
branch
from
July 22, 2026 01:02
a2d47bc to
3948550
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
RCTStatusBarManager'ssetStyle:andsetHidden:already no-op whenUIViewControllerBasedStatusBarAppearanceisYES. Currently this path emitsRCTLogError, which redboxes in dev and logs a soft error in release — eventhough the call is an expected no-op when the view controller owns the status bar.
Downgrade to
RCTLogWarnwith a more accurate message so apps adoptingVC-based status bar appearance aren't flooded with spurious errors on every
StatusBar.setBarStyle/setHiddencall or<StatusBar>mount.No behavior change; the methods remain no-ops under the flag.
Changelog: [iOS][Changed] - Downgrade RCTStatusBarManager error to a warning when UIViewControllerBasedStatusBarAppearance is YES
Differential Revision: D113043635