Skip to content

feat(frontier): add upper bounds to pagination page_size and rql limit fields#492

Merged
AmanGIT07 merged 1 commit into
mainfrom
feat/frontier-pagination-limits
Jul 24, 2026
Merged

feat(frontier): add upper bounds to pagination page_size and rql limit fields#492
AmanGIT07 merged 1 commit into
mainfrom
feat/frontier-pagination-limits

Conversation

@AmanGIT07

Copy link
Copy Markdown
Contributor

Adds a maximum bound of 5000, using buf.validate lte rules, to:

  • page_size in ListUsersRequest, ListProjectsByCurrentUserRequest, ListOrganizationsRequest (frontier.proto)
  • page_size in ListAllUsersRequest, ListAllOrganizationsRequest, ListAllInvoicesRequest (admin.proto)
  • limit in the shared RQLRequest (models.proto)

Zero still means unset and keeps server-side defaults. Values from 1 to 5000 are accepted as before.

🤖 Generated with Claude Code

…t fields

Caps page_size on the six paginated list request messages and the shared
RQLRequest limit at 5000 via buf.validate lte rules.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Validate / validate (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedJul 23, 2026, 12:06 PM

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7fe0efbf-e428-4c21-babd-92c147094017

📥 Commits

Reviewing files that changed from the base of the PR and between f0b06e6 and b2d1e93.

📒 Files selected for processing (3)
  • raystack/frontier/v1beta1/admin.proto
  • raystack/frontier/v1beta1/frontier.proto
  • raystack/frontier/v1beta1/models.proto

📝 Walkthrough

Walkthrough

The protobuf definitions now cap pagination-related values at 5000. Six list request page_size fields retain their minimum validation, with administrative requests preserving zero-value handling. RQLRequest.limit now also enforces a maximum of 5000.

Suggested reviewers: rohilsurana, whoabhisheksah

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding upper bounds to pagination and RQL limit fields.
Description check ✅ Passed The description matches the changeset and correctly lists the updated validation rules and fields.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AmanGIT07
AmanGIT07 merged commit f90d337 into main Jul 24, 2026
3 checks passed
@AmanGIT07
AmanGIT07 deleted the feat/frontier-pagination-limits branch July 24, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants