Skip to content

gh-154502: Disable junk filling in the OpenBSD allocator in test_capi#154503

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:capi-mem-openbsd-junk
Jul 22, 2026
Merged

gh-154502: Disable junk filling in the OpenBSD allocator in test_capi#154503
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:capi-mem-openbsd-junk

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 22, 2026

Copy link
Copy Markdown
Member

OpenBSD's allocator fills freed memory with junk by default and is configured by MALLOC_OPTIONS, not by jemalloc's MALLOC_CONF, so the pattern written by the debug hooks did not survive free() and test_pyobject_freed_is_freed failed.

Verified on OpenBSD 7.9: test_capi FAILURE -> SUCCESS.

…t_capi

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jul 22, 2026
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes skip news labels Jul 22, 2026
@serhiy-storchaka
serhiy-storchaka merged commit 206788a into python:main Jul 22, 2026
59 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jul 22, 2026

Copy link
Copy Markdown

GH-154513 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 22, 2026
@bedevere-app

bedevere-app Bot commented Jul 22, 2026

Copy link
Copy Markdown

GH-154514 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 22, 2026
@bedevere-app

bedevere-app Bot commented Jul 22, 2026

Copy link
Copy Markdown

GH-154515 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 22, 2026
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot wasm32-wasi 3.x (tier-2) has failed when building commit 206788a.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1046/builds/12536) and take a look at the build logs.
  4. Check if the failure is related to this commit (206788a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1046/builds/12536

Failed tests:

  • test_zipfile

Failed subtests:

  • test_write_filtered_python_package - test.test_zipfile.test_core.PyZipFileTests.test_write_filtered_python_package

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/Lib/test/test_zipfile/test_core.py", line 3650, in test_write_filtered_python_package
    zipfp.writepy(packagedir, filterfunc=filter)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Lib/zipfile/__init__.py", line 2809, in writepy
    self.writestr(arcname, bytecode)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
  File "/Lib/zipfile/__init__.py", line 2580, in writestr
    dest.write(data)
    ~~~~~~~~~~^^^^^^
  File "/Lib/zipfile/__init__.py", line 1357, in write
    self._fileobj.write(data)
    ~~~~~~~~~~~~~~~~~~~^^^^^^
OSError: [Errno 51] No space left on device

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants