gh-139445: Skip pyrepl tests if the terminal is not supported#154497
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-139445: Skip pyrepl tests if the terminal is not supported#154497serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
They were only skipped if TERM was unset or "dumb", but pyrepl also needs the terminal to have several capabilities. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
requested review from
ambv,
lysnikolaou and
pablogsal
as code owners
July 22, 2026 16:56
serhiy-storchaka
added
needs backport to 3.14
Contributor
|
Is the use of Line 548 in 3479e45 |
pablogsal
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestMainwas only skipped ifTERMwas unset ordumb, but pyrepl needs the terminal to have thebel,clear,cupandelcapabilities. Without them it falls back to the basic REPL, and six tests which type bareexitwait for the timeout.Checking the capabilities subsumes the unset/
dumbcase.when can't use pyrepl#139445