gh-154431: Use existing runtime->audit_hooks.mutex instead of a new one#154494
Open
sobolevn wants to merge 1 commit into
Open
gh-154431: Use existing runtime->audit_hooks.mutex instead of a new one#154494sobolevn wants to merge 1 commit into
runtime->audit_hooks.mutex instead of a new one#154494sobolevn wants to merge 1 commit into
Conversation
sobolevn
requested review from
FFY00,
ZeroIntensity and
ericsnowcurrently
as code owners
July 22, 2026 16:30
ZeroIntensity
left a comment
ZeroIntensity
left a comment
Member
There was a problem hiding this comment.
This will just increase contention in sys.addaudithook, won't it?
Member
Author
|
I don't think that we actually concurrenly add hooks with both |
sobolevn
added
skip news
needs backport to 3.14
Member
|
Agreed, but why make this change at all? We're just increasing pressure on a lock for no reason. |
Member
Author
|
Because we can't backport the fix with interpreter state changed due to ABI change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sys.addaudithook()lazily createsinterp->audit_hookswith no lock #154431