Fix "ob_get_*() === false will always evaluate to false" false positive

[staabm]

Fixes phpstan/phpstan#14985

[phpstan-bot]

This pull request has been marked as ready for review.

[VincentLanglet]

I don't like this fix cause this just seems to be a hack in order to satisfy one issue but some others could be open like the fact that ob_get_level doesn't return the right value if a ob_start fail.

Honestly I wonder if we should just revert #5964
Looking at the original issue phpstan/phpstan#10348 it was already wrong since the author didn't check the return value from ob_start. We shouldn't make the asumption it worked if the author don't check it.

The right fix is technically #6087 but maybe we could simplify it.

[staabm]

Looking at the original issue phpstan/phpstan#10348 it was already wrong since the author didn't check the return value from ob_start. We shouldn't make the asumption it worked if the author don't check it.

IMO the whole point of this issue was/is, that checking error state return values of ob_* functions is essentially useless as this usually means that your system is out of memory and your process is going to die anyway.

thats why error states are not checked.
and in phpstan/phpstan#14985 error states, which are "not that useful" are checked, which leads to these errors.

so thats why I think benevolent is the right tool for the job, as it helps us to treat not important error states in a less aggressive way

[VincentLanglet]

IMO the whole point of this issue was/is, that checking error state return values of ob_* functions is essentially useless as this usually means that your system is out of memory and your process is going to die anyway.

I kinda agree with your fix. I'm just annoyed by the assertiong

assertType('int<1, max>', ob_get_level());

It's like ob_start could technically fail for ob_clean but not for ob_get_level...

Anyway that might be good enough.
Maybe might be worth to add a comment above the benevolentUnion to explain the reason ?

[staabm]

thank you @VincentLanglet