Conversation
📝 WalkthroughWalkthroughAPI URL configuration now uses ChangesAPI URL configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@config/parameters.yml.dist`:
- Around line 37-39: Normalize API_BASE_URL to remove any trailing slash before
appending /api/v2 in app.rest_api_base_url, while preserving app.api_base_url
and downstream URL values without duplicate slashes. Ensure the default
configuration and deployment-provided values follow the same no-trailing-slash
behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: a9189fb3-cd53-4927-a570-613d605161a1
📒 Files selected for processing (1)
config/parameters.yml.dist
| app.rest_api_base_url: '%%env(API_BASE_URL)%%/api/v2' | ||
| app.api_base_url: '%%env(API_BASE_URL)%%' | ||
| env(API_BASE_URL): 'http://api.phplist.local/' |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Normalize the API base URL before appending /api/v2.
The default API_BASE_URL ends with /, so this composition produces http://api.phplist.local//api/v2. Any deployment value with a trailing slash has the same problem, affecting downstream URLs and HTTP stamp values. Either remove the slash from the default and enforce a no-trailing-slash contract, or normalize the value before concatenation.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@config/parameters.yml.dist` around lines 37 - 39, Normalize API_BASE_URL to
remove any trailing slash before appending /api/v2 in app.rest_api_base_url,
while preserving app.api_base_url and downstream URL values without duplicate
slashes. Ensure the default configuration and deployment-provided values follow
the same no-trailing-slash behavior.
Summary by CodeRabbit
/api/v2path.Thanks for contributing to phpList!