Do not abort cross-origin requests with an empty 200 (#1955)#1975
Open
svpernova09 wants to merge 1 commit into
Open
Do not abort cross-origin requests with an empty 200 (#1955)#1975svpernova09 wants to merge 1 commit into
svpernova09 wants to merge 1 commit into
Conversation
svpernova09
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
July 24, 2026 02:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to reproduce
Same URL, same server. One request-header a client fully controls turns the page into a zero-byte 200 OK.
exit(10)atinclude/prepend.inc:31sets a process exit status and emits no body, so the response is a perfectlyvalid success with nothing in it.
That empty body then gets cached and served to everyone: Origin is not part of the CDN cache key and we send no Vary
header. It also persists, because Cache-Control: public, max-age=300 is set later in include/header.inc:54 and never
runs, so the CDN applies its own default TTL instead of five minutes.
On this branch: