Remove param argument from php_verror#22865
Open
NattyNarwhal wants to merge 6 commits into
Open
Conversation
Now that docref has been knocked out and error_include_args exists, remove this argument. Callers will be updated accordingly.
NattyNarwhal
force-pushed
the
remove-params-verror
branch
from
July 22, 2026 21:36
78933b4 to
759a1a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update tests and
UPGRADING.INTERNALS.Note there is some impact to extensions if they call this; however, it's usually in a centralized wrapper function which is easy to update. In my quick skim of external extensions, apcu is the only maintained one that'll need an update.
Also note that
php_verroris a bit weirdly named. It should probably be called something likephp_docref_verror, sincephp_error_docrefthe vararg wrapper around it (now that 1/2 are gone); let me know if this is something worth pursuing. There isphp_error, which is just an alias forzend_error, which doesn't take a docref, nor does it have the function and args prefix thatphp_verrorhas. It should be used for engine stuff, but I think there are a few places where it's called from places wherephp_error_docrefshould be used instead in extensions. I can take a look at that too.