Skip to content

Drop url.pecl.windows.releases entity declaration#143

Merged
kamil-tekiela merged 2 commits into
php:masterfrom
cmb69:cmb/pecl-windows-releases
Jul 24, 2026
Merged

Drop url.pecl.windows.releases entity declaration#143
kamil-tekiela merged 2 commits into
php:masterfrom
cmb69:cmb/pecl-windows-releases

Conversation

@cmb69

@cmb69 cmb69 commented Aug 1, 2024

Copy link
Copy Markdown
Member

If php/doc-en#3633 will be merged, there are no remaining uses of that entity in doc-en, so after translations have caught up, the entity declaration can be removed.

If php/doc-en#3633 will be merged, there are no
remaining uses of that entity in doc-en, so after translations have
caught up, the entity declaration can be removed.
philip added a commit to php/doc-en that referenced this pull request Feb 22, 2025
…ties were

added to global.ent via php/doc-base@f8bdf40
Sorry translators for this extra work!
Note: Notes containing 'windows.php.net/downloads/pecl/releases' were
removed as the associated entity will disappear one day via php/doc-base#143
@philip

philip commented Feb 25, 2025

Copy link
Copy Markdown
Member

There was one remaining reference in install/windows/manual.xml that's now gone, so it'll be awhile longer before translations catch up.

@alfsb

alfsb commented Jul 17, 2026

Copy link
Copy Markdown
Member

There is no need to wait for translations to catch up. Any entity removed from doc-base or doc-en can be "moved" to doc-en/entities/entities.remove.ent , or declared empty there, so translations keep building and are alerted about removed entities.

There is a reported issue where entity references in entities contents are being lost, something that I try to fix in the next few days.

@alfsb

alfsb commented Jul 23, 2026

Copy link
Copy Markdown
Member

doc-ru still uses it. I will "move" it into entities.remove.ent, so this can be merged before convertion to XML start.

@alfsb

alfsb commented Jul 24, 2026

Copy link
Copy Markdown
Member

This can now be merged.

As note above, and demonstred in PR 5704 also linked above, now it is possible to remove DTD entities from doc-en in one go, be the entity declared in doc-en or doc-base, without breaking translations.

Happy DTD entity hacking!

@kamil-tekiela
kamil-tekiela merged commit c45b8a3 into php:master Jul 24, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants