Security: Reflected XSS via innerHTML using URL parameters - #3053
Closed
tomaioo wants to merge 1 commit into
Closed
Conversation
The `applyTranslations` function reads URL parameters `mainHeading` and `mainSpan` and directly inserts them into the DOM using the `innerHTML` property. This occurs after decoding the URI component. An attacker can craft a malicious URL containing JavaScript payloads within these parameters. When a victim visits the crafted URL, the script will execute in the context of the victim's browser, leading to reflected Cross-Site Scripting (XSS). Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
Member
|
This a frequent issue flagged by AI tools which is a false positive. Same issue raised before at #2985 Please tune your AI to ignore this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Reflected XSS via innerHTML using URL parameters
Problem
Severity:
High| File:src-node/www/phoenix-splash/error.html:L9The
applyTranslationsfunction reads URL parametersmainHeadingandmainSpanand directly inserts them into the DOM using theinnerHTMLproperty. This occurs after decoding the URI component. An attacker can craft a malicious URL containing JavaScript payloads within these parameters. When a victim visits the crafted URL, the script will execute in the context of the victim's browser, leading to reflected Cross-Site Scripting (XSS).Solution
Avoid using
innerHTMLwith untrusted input. Instead, usetextContentordocument.createElementto safely construct the DOM elements. If HTML formatting is strictly required, sanitize the input using a robust HTML sanitization library like DOMPurify before insertion.Changes
src-node/www/phoenix-splash/error.html(modified)