Skip to content

[DRAFT] Experimental revert of #2920 — payload upgrade test#2953

Closed
redhat-chai-bot wants to merge 1 commit into
openshift:masterfrom
redhat-chai-bot:revert-2920
Closed

[DRAFT] Experimental revert of #2920 — payload upgrade test#2953
redhat-chai-bot wants to merge 1 commit into
openshift:masterfrom
redhat-chai-bot:revert-2920

Conversation

@redhat-chai-bot

Copy link
Copy Markdown

Reverts #2920

Experimental revert — do NOT merge. This draft PR tests whether reverting the OLMLifecycleAndCompatibility feature gate promotion resolves the 4.22→5.0 major upgrade failures in the aggregated-aws-ovn-upgrade-5.0-major blocking job.

Failure pattern: config-operator never sets Progressing=True during major upgrade, causing CVO invariant config-operator must go Progressing=True during an upgrade to fail. The CVO sync loop restarts extend the wait beyond 3 minutes.

Stream blocked: 5.0 CI — 5 consecutive rejections, 38+ hours blocked (last accepted: 5.0.0-0.ci-2026-07-23-195533).

Payload jobs will be triggered on this PR to validate.


@stbenjam requested in Slack thread

@openshift-ci

openshift-ci Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Hello @redhat-chai-bot! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@redhat-chai-bot

Copy link
Copy Markdown
Author

/payload-job periodic-ci-openshift-release-main-ci-5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 6b78dd32-3022-43ff-8337-a35822912311

📥 Commits

Reviewing files that changed from the base of the PR and between 61abf80 and 2411df1.

📒 Files selected for processing (4)
  • features.md
  • features/features.go
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
🚧 Files skipped from review as they are similar to previous changes (3)
  • features/features.go
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
  • features.md

📝 Walkthrough

Walkthrough

The OLMLifecycleAndCompatibility feature gate now enables only for SelfManaged DevPreviewNoUpgrade and TechPreviewNoUpgrade profiles. The feature matrix reflects this eligibility, and the Default and OKD SelfManagedHA payload manifests list the gate as disabled.

Suggested reviewers: everettraven, joelspeed

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: an experimental revert of PR #2920 for payload upgrade testing.
Description check ✅ Passed The description is directly about reverting OLMLifecycleAndCompatibility to test major-upgrade failures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The PR only changes feature-gate metadata/manifests; no It/Describe/Context/When titles or string-formatted test names appear in the modified files.
Test Structure And Quality ✅ Passed PASS: The PR only changes feature-gate docs/code/manifests; no Ginkgo test blocks, setup/cleanup, or timeout patterns are affected.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the PR only edits feature-gate metadata and payload manifests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo e2e tests were added; the PR only changes feature-gate docs, Go gating logic, and payload manifests.
Topology-Aware Scheduling Compatibility ✅ Passed PR only updates feature-gate metadata/manifests for OLMLifecycleAndCompatibility; no workload specs, affinity, node selectors, replicas, or PDBs were added.
Ote Binary Stdout Contract ✅ Passed Changed files are metadata-only (features.go/YAML/docs); no main/init/TestMain/suite setup or stdout-printing code was added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: PR only changes feature-gate docs/go/manifests; no new Ginkgo tests or IPv4/public-internet assumptions were added.
No-Weak-Crypto ✅ Passed PASS: The PR only edits feature-gate docs/manifests and one gate registration; no weak-crypto algorithms, custom crypto, or secret comparisons appear in the diff.
Container-Privileges ✅ Passed Touched files only update feature-gate lists; no privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings appear.
No-Sensitive-Data-In-Logs ✅ Passed PR only changes feature-gate enablement/manifests; no new logging or sensitive-data strings appear in the edited files.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8cdbc700-8854-11f1-96dd-3a5bf6314f3e-0

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 25, 2026
@openshift-ci
openshift-ci Bot requested review from JoelSpeed and everettraven July 25, 2026 18:14
@openshift-ci

openshift-ci Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@redhat-chai-bot

Copy link
Copy Markdown
Author

/payload-aggregate periodic-ci-openshift-release-main-ci-5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade 5

@openshift-ci

openshift-ci Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/91d3ff90-887f-11f1-9996-b364db4e7190-0

@redhat-chai-bot

Copy link
Copy Markdown
Author

/payload-aggregate periodic-ci-openshift-release-main-ci-5.0-upgrade-from-stable-4.22-e2e-azure-ovn-upgrade 5

@openshift-ci

openshift-ci Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-upgrade-from-stable-4.22-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/952cc780-887f-11f1-9bed-b113d6d6121d-0

…-lifecycle-default"

This reverts commit 18550f1, reversing
changes made to 356624f.
@openshift-ci

openshift-ci Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-hypershift-integration 2411df1 link true /test verify-hypershift-integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant