fix(idp): serve the real identifier app for welcome/goodbye/consent/chooseaccount#3174
Open
kost wants to merge 1 commit into
Open
fix(idp): serve the real identifier app for welcome/goodbye/consent/chooseaccount#3174kost wants to merge 1 commit into
kost wants to merge 1 commit into
Conversation
…hooseaccount
The vendored lico library registers /welcome, /goodbye, /consent, and
/chooseaccount (alongside /identifier) as routes served by its own
built-in identifier webapp
(vendor/github.com/libregraph/lico/identifier/identifier.go). That
built-in webapp's index.html is only ever read from disk when
IdentifierClientDisabled is false -- but OpenCloud always runs with it
true, since services/idp/pkg/service/v0/service.go's Index() serves
our own, correctly-templated identifier app instead. Previously only
/signin/v1/identifier (and its trailing-slash/index.html variants) was
overridden this way; hitting any of the other four directly -- a
bookmarked URL, or a SAML logout redirect via
absoluteURLForRoute("goodbye") -- reached lico's handler instead,
which writes a permanently-empty webappIndexHTML: HTTP 200 with a
literally empty body, and nothing rendered.
All five are routes the identifier app's own client-side router
(services/idp/src/Routes.jsx) already recognizes, so serving our real
index.html for all of them is enough to fix this.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(idp): serve the real identifier app for welcome/goodbye/consent/chooseaccount
The vendored lico library registers /welcome, /goodbye, /consent, and /chooseaccount (alongside /identifier) as routes served by its own built-in identifier webapp
(vendor/github.com/libregraph/lico/identifier/identifier.go). That built-in webapp's index.html is only ever read from disk when IdentifierClientDisabled is false - but OpenCloud always runs with it true, since services/idp/pkg/service/v0/service.go's Index() serves our own, correctly-templated identifier app instead. Previously only /signin/v1/identifier (and its trailing-slash/index.html variants) was overridden this way; hitting any of the other four directly - a bookmarked URL, or a SAML logout redirect via
absoluteURLForRoute("goodbye") - reached lico's handler instead, which writes a permanently-empty webappIndexHTML: HTTP 200 with a literally empty body, and nothing rendered.
All five are routes the identifier app's own client-side router (services/idp/src/Routes.jsx) already recognizes, so serving our real index.html for all of them is enough to fix this.
Types of changes