src: require watchdog status pointers#64667
Open
Archkon wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
added
c++
Remove the nullptr defaults from Watchdog and SigintWatchdog result parameters. Both watchdogs unconditionally dereference these pointers, so callers must explicitly provide valid status storage. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Archkon
force-pushed
the
watchdog
branch
2 times, most recently
from
July 22, 2026 07:48
c7b0efa to
78d9f11
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64667 +/- ##
==========================================
+ Coverage 90.12% 90.16% +0.04%
==========================================
Files 741 741
Lines 242149 242459 +310
Branches 45574 45802 +228
==========================================
+ Hits 218229 218623 +394
+ Misses 15447 15332 -115
- Partials 8473 8504 +31
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the nullptr defaults from Watchdog and SigintWatchdog result parameters. Both watchdogs unconditionally dereference these pointers, so callers must explicitly provide valid status storage.