ffi: fix optimized buffer conversions#64639
Open
trivikr wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
ShogunPanda
approved these changes
Jul 21, 2026
trivikr
added
author ready
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64639 +/- ##
==========================================
- Coverage 90.14% 90.12% -0.02%
==========================================
Files 741 741
Lines 242112 242093 -19
Branches 45605 45602 -3
==========================================
- Hits 218244 218186 -58
- Misses 15360 15393 +33
- Partials 8508 8514 +6
🚀 New features to boost your workflow:
|
Collaborator
Preserve pointer-like argument conversions for buffer and arraybuffer signatures after Fast API optimization. Keep memory-backed arguments on the specialized native fast path. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.6-sol
trivikr
force-pushed
the
ffi-buffer-sig-bigint
branch
from
July 23, 2026 04:38
3dd2628 to
139053a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64638
Fast FFI calls with
bufferorarraybufferargument signatures accepted pointer-like values through the generic path, but rejected non-memory-backed values after optimization.This change keeps the primary optimized entry point compatible with raw pointer conversions while retaining the specialized native fast path for memory-backed arguments. Optimized calls now consistently accept documented representations including
bigint, strings, nullish values, buffers, typed arrays, andArrayBufferobjects.Assisted-by: openai:gpt-5.6-sol