Skip to content

fix: bump deps#113

Merged
avivkeller merged 3 commits into
mainfrom
ui-components
Jul 23, 2026
Merged

fix: bump deps#113
avivkeller merged 3 commits into
mainfrom
ui-components

Conversation

@avivkeller

@avivkeller avivkeller commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Copilot AI review requested due to automatic review settings July 21, 2026 23:42
@avivkeller
avivkeller requested a review from a team as a code owner July 21, 2026 23:42
Copilot AI reviewed Jul 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vercel

vercel Bot commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-learn Ready Ready Preview Jul 23, 2026 4:18pm

Request Review

@cursor

cursor Bot commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown

PR Summary

Low Risk
Single prop addition for nav highlighting under /learn; no auth, data, or API changes.

Overview
Updates navigation after dependency bumps (per #9018) by passing pathname="/learn" into @node-core/ui-components NavBar.

That aligns top-nav active-state / routing behavior with this site’s /learn base path (same idea as SideBar and Vercel basePath), which the bumped @node-core/ui-components likely expects explicitly.

Reviewed by Cursor Bugbot for commit b78fd54. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

Copilot AI review requested due to automatic review settings July 21, 2026 23:44
Copilot AI reviewed Jul 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@avivkeller avivkeller changed the title fix: update ui-components fix: bump deps Jul 21, 2026
@AugustinMauroy

AugustinMauroy commented Jul 23, 2026

Copy link
Copy Markdown
Member

Why not using dependabot ?

@avivkeller

avivkeller commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

We have Dependabot, but this is to fix a bug in ui components

Copilot AI review requested due to automatic review settings July 23, 2026 16:17
Copilot AI reviewed Jul 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@avivkeller
avivkeller added this pull request to the merge queue Jul 23, 2026
Merged via the queue into main with commit 00f6d43 Jul 23, 2026
7 checks passed
@avivkeller
avivkeller deleted the ui-components branch July 23, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Strange sidebar scroll behaviour on long pages

3 participants

@avivkeller @AugustinMauroy