-
Notifications
You must be signed in to change notification settings - Fork 2k
chore: migrate to package.json-based linting package management #2576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,13 @@ | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: github-actions | ||
| directory: '/' | ||
| directory: / | ||
| schedule: | ||
| interval: daily | ||
| interval: weekly | ||
| open-pull-requests-limit: 10 | ||
| - package-ecosystem: npm | ||
| directory: / | ||
| schedule: | ||
| interval: weekly | ||
| cooldown: | ||
| default-days: 5 |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -3,9 +3,12 @@ name: Check generated TOCs | |||||
| on: | ||||||
| pull_request: | ||||||
| paths: | ||||||
| - 'README.md' | ||||||
| - 'docs/BestPractices.md' | ||||||
| - '.github/workflows/doctoc.yml' | ||||||
| - README.md | ||||||
| - CONTRIBUTING.md | ||||||
| - docs/BestPractices.md | ||||||
| - .github/workflows/doctoc.yml | ||||||
| - 'package*.json' | ||||||
| workflow_dispatch: | ||||||
|
|
||||||
| permissions: | ||||||
| contents: read | ||||||
|
|
@@ -15,17 +18,16 @@ jobs: | |||||
| name: Doc TOC Check | ||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||||||
| - uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||||||
| - name: Check out repo | ||||||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||||||
| - name: Set up Node.js | ||||||
| uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||||||
| with: | ||||||
| node-version: 'lts/*' | ||||||
| - name: Install doctoc | ||||||
| run: npm i -g doctoc | ||||||
| - name: Create README copy and diff with doctoc | ||||||
| run: cp README.md README.md.tmp && | ||||||
| doctoc --title='## Table of Contents' --github README.md && | ||||||
| diff -q README.md README.md.tmp | ||||||
| - name: Create "docs/BestPractices.md" copy and diff with doctoc | ||||||
| run: cp docs/BestPractices.md docs/BestPractices.md.tmp && | ||||||
| doctoc --title='## Table of Contents' --github docs/BestPractices.md && | ||||||
| diff -q docs/BestPractices.md docs/BestPractices.md.tmp | ||||||
| node-version-file: .node-version | ||||||
| cache: npm | ||||||
| - name: Install dependencies | ||||||
| run: npm ci | ||||||
| - name: Run doctoc | ||||||
| run: npx doctoc --update-only . | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| - name: Check for changes | ||||||
| run: git diff --exit-code | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,8 +4,10 @@ on: | |
| pull_request: | ||
| paths: | ||
| - '**/*.md' | ||
| - 'markdown_link_check_config.json' | ||
| - '.github/workflows/markdown-link-check.yml' | ||
| - markdown_link_check_config.json | ||
| - .github/workflows/markdown-link-check.yml | ||
|
MikeMcC399 marked this conversation as resolved.
|
||
| - 'package*.json' | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
@@ -14,11 +16,14 @@ jobs: | |
| markdown-link-check: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| - uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||
| - name: Check out repo | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| - name: Set up Node.js | ||
| uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||
| with: | ||
| node-version: 'lts/*' | ||
| - name: Install markdown-link-check | ||
| run: npm i -g markdown-link-check@3.14.2 | ||
| node-version-file: .node-version | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is picked up automatically and doesn't need to be configured
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If neither I did try it out, just to make sure. So this needs to stay as it is. |
||
| cache: npm | ||
| - name: Install dependencies | ||
| run: npm ci | ||
| - name: Run markdown-link-check on MD files | ||
| run: find . -name "*.md" | xargs -n 1 markdown-link-check -c markdown_link_check_config.json -q | ||
| run: npm run check:markdown-links | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||
| name: Check Prettier formatting | ||||||
|
|
||||||
| on: [pull_request] | ||||||
| on: [pull_request, workflow_dispatch] | ||||||
|
|
||||||
| permissions: | ||||||
| contents: read | ||||||
|
|
@@ -9,8 +9,14 @@ jobs: | |||||
| prettier: | ||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||||||
| - uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||||||
| - name: Check out repo | ||||||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||||||
| - name: Set up Node.js | ||||||
| uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||||||
| with: | ||||||
| node-version: 'lts/*' | ||||||
| - run: npx prettier@3.9.5 --check . | ||||||
| node-version-file: .node-version | ||||||
| cache: npm | ||||||
| - name: Install dependencies | ||||||
| run: npm ci | ||||||
| - name: Run Prettier | ||||||
| run: npx prettier --check . | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Better to call the configured target |
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| node_modules/ |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 24 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| min-release-age=5 | ||
| save-exact=true |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 24 |
Uh oh!
There was an error while loading. Please reload this page.