Split phabricator.submit_patch into submit_patch and update_patch#6382
Draft
suhaibmujahid wants to merge 1 commit into
Draft
Split phabricator.submit_patch into submit_patch and update_patch#6382suhaibmujahid wants to merge 1 commit into
suhaibmujahid wants to merge 1 commit into
Conversation
suhaibmujahid
force-pushed
the
worktree-split-phab-patch-actions
branch
from
July 27, 2026 04:53
596fd69 to
bfe005e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phabricator.submit_patchdid double duty: create a revision, or update one if an optionalrevision_idwas passed. That put the create-vs-update decision entirely on the agent getting one optional argument right. Omit it by mistake and a new revision appears instead of the intended update; pass a guessed number and an unrelated revision gets a new diff.