Skip to content

lib: add Math.sumPrecise type definition (ES2025)#63589

Closed
kamalkarki111 wants to merge 1 commit into
microsoft:mainfrom
kamalkarki111:add-math-sumPrecise-lib-type
Closed

lib: add Math.sumPrecise type definition (ES2025)#63589
kamalkarki111 wants to merge 1 commit into
microsoft:mainfrom
kamalkarki111:add-math-sumPrecise-lib-type

Conversation

@kamalkarki111

Copy link
Copy Markdown

Summary

Adds type definition for Math.sumPrecise which is part of the TC39 proposal-math-sum that reached Stage 4 on 2025-07-28, making it part of ES2026.

Changes

  • New file: src/lib/esnext.math.d.ts — extends interface Math with sumPrecise
  • Updated src/lib/esnext.d.ts — added /// <reference lib="esnext.math" />
  • Updated src/lib/libs.json — registered esnext.math in the libs array
  • Updated src/compiler/commandLineParser.ts — mapped esnext.math lib name to file
  • Updated src/compiler/utilities.ts — added sumPrecise to ScriptTargetFeatures for helpful diagnostics

Why esnext, not es2025?

The proposal reached Stage 4 on 2025-07-28, one month after ES2025 was finalized (June 2025), so it will be included in ES2026. TypeScript does not have es2026 lib files yet, so esnext is the correct placement for now.

Runtime support

Runtime Supported
Firefox 137+
Safari 18.4 (JavaScriptCore)
Bun
V8 / Node.js / Chrome ❌ not yet

References

Based on the same changes as #63429

Math.sumPrecise is part of the TC39 proposal-math-sum which reached
Stage 4 on 2025-07-28, making it part of ES2026.

Already implemented in Firefox 137+, Safari 18.4, and Bun,
but not yet in V8/Node.js.

Adds src/lib/esnext.math.d.ts with the Math interface extension,
and wires it into esnext.d.ts and libs.json.

Fixes microsoft#63427
Copilot AI review requested due to automatic review settings June 26, 2026 13:16
@github-project-automation github-project-automation Bot moved this to Not started in PR Backlog Jun 26, 2026
@typescript-automation typescript-automation Bot added For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 26, 2026
@typescript-automation

Copy link
Copy Markdown

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

1 similar comment
@typescript-automation

Copy link
Copy Markdown

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new esnext lib slice for the Stage 4 Math.sumPrecise proposal and wires it into lib selection, diagnostics, and conformance coverage.

Changes:

  • Introduces src/lib/esnext.math.d.ts to declare Math.sumPrecise(numbers: Iterable<number>): number.
  • Registers the new lib name (esnext.math) and ensures it is reachable via /// <reference lib="..."> and --lib.
  • Adds a conformance test plus updated baselines reflecting the new --lib option value.

Reviewed changes

Copilot reviewed 14 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/cases/conformance/esnext/mathSumPrecise.ts New conformance test exercising Math.sumPrecise typing under @lib: esnext.
tests/baselines/reference/mathSumPrecise.types New baseline validating inferred types for the conformance test.
tests/baselines/reference/mathSumPrecise.symbols New baseline validating symbol resolution for Math.sumPrecise.
tests/baselines/reference/config/convertCompilerOptionsFromJson/Convert trailing-whitespace string option of libs to compiler-options with jsonSourceFile api.js Baseline update to include esnext.math in TS6046 allowed --lib values.
tests/baselines/reference/config/convertCompilerOptionsFromJson/Convert trailing-whitespace string option of libs to compiler-options with json api.js Baseline update to include esnext.math in TS6046 allowed --lib values.
tests/baselines/reference/config/convertCompilerOptionsFromJson/Convert incorrect option of libs to compiler-options with jsonSourceFile api.js Baseline update to include esnext.math in TS6046 allowed --lib values.
tests/baselines/reference/config/convertCompilerOptionsFromJson/Convert incorrect option of libs to compiler-options with json api.js Baseline update to include esnext.math in TS6046 allowed --lib values.
tests/baselines/reference/config/convertCompilerOptionsFromJson/Convert empty string option of libs to compiler-options with jsonSourceFile api.js Baseline update to include esnext.math in TS6046 allowed --lib values.
tests/baselines/reference/config/convertCompilerOptionsFromJson/Convert empty string option of libs to compiler-options with json api.js Baseline update to include esnext.math in TS6046 allowed --lib values.
tests/baselines/reference/config/convertCompilerOptionsFromJson/Convert empty string option of libs array to compiler-options with jsonSourceFile api.js Baseline update to include esnext.math in TS6046 allowed --lib values.
tests/baselines/reference/config/convertCompilerOptionsFromJson/Convert empty string option of libs array to compiler-options with json api.js Baseline update to include esnext.math in TS6046 allowed --lib values.
tests/baselines/reference/config/commandLineParsing/parseCommandLine/Parse invalid option of library flags.js Baseline update to include esnext.math in TS6046 allowed --lib values.
tests/baselines/reference/config/commandLineParsing/parseCommandLine/Parse --lib option with trailing white-space.js Baseline update to include esnext.math in TS6046 allowed --lib values.
tests/baselines/reference/config/commandLineParsing/parseCommandLine/Parse --lib option with extra comma.js Baseline update to include esnext.math in TS6046 allowed --lib values.
src/lib/libs.json Registers esnext.math in the known lib-name list.
src/lib/esnext.math.d.ts New lib slice adding the Math.sumPrecise declaration.
src/lib/esnext.d.ts Ensures esnext includes esnext.math via a lib reference.
src/compiler/utilities.ts Adds sumPrecise to ScriptTargetFeatures for Math under esnext (used for lib/target suggestion diagnostics).
src/compiler/commandLineParser.ts Maps --lib esnext.math to lib.esnext.math.d.ts.
Files not reviewed (3)
  • tests/baselines/reference/config/commandLineParsing/parseCommandLine/Parse --lib option with extra comma.js: Generated file
  • tests/baselines/reference/config/commandLineParsing/parseCommandLine/Parse --lib option with trailing white-space.js: Generated file
  • tests/baselines/reference/config/commandLineParsing/parseCommandLine/Parse invalid option of library flags.js: Generated file

Comment on lines 251 to 254
// ESNext By-feature options
["esnext.array", "lib.esnext.array.d.ts"],
["esnext.array", "lib.esnext.array.d.ts"],
["esnext.math", "lib.esnext.math.d.ts"],
["esnext.collection", "lib.esnext.collection.d.ts"],
Comment thread src/lib/libs.json
Comment on lines 89 to 92
"esnext.array",
"esnext.math",
"esnext.collection",
"esnext.date",
Comment on lines +18 to +22
function* gen(): Iterable<number> {
yield 0.1;
yield 0.2;
}
const sum5 = Math.sumPrecise(gen());
@MartinJohns

Copy link
Copy Markdown
Contributor

Duplicate of #63429.

@github-project-automation github-project-automation Bot moved this from Not started to Done in PR Backlog Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants