fix(go): stop replacing host process signal handlers during install#411
Open
WellMafra wants to merge 1 commit into
Open
fix(go): stop replacing host process signal handlers during install#411WellMafra wants to merge 1 commit into
WellMafra wants to merge 1 commit into
Conversation
WellMafra
marked this pull request as ready for review
July 22, 2026 20:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
signal.Notify(SIGINT/SIGTERM/SIGKILL/SIGQUIT)block and its cancellation goroutine from the native install path;RunWithContextnow receives a plaincontext.Background()HelmSignalHandlerTest, a black-box test that runs a client-only install in a child JVM, sends it SIGTERM viaProcess.destroy(), and asserts it exits with code 143 within 15s (disabled on Windows)Why
signal.Notifycall makes the in-process Go runtime permanently replace the host process' OS-level SIGINT/SIGTERM handlers. Embedding JVMs then ignore SIGTERM — shutdown hooks never run and Kubernetes pods hang until the kubelet SIGKILLs them afterterminationGracePeriodSecondssignal.Notifyenabled was never reachable for embedders anyway (no CLI context), and each call also leaked a goroutine blocked on the signal channel;SIGKILLin the list was a no-op since it cannot be caughtupgrade.goreaches this same path viaInstall()when the release doesn't exist, soupgrade --installis covered tooVerified: the new test fails against the previous native library (child JVM ignores SIGTERM and times out) and passes with this change;
HelmInstallTest(19 tests) still green;gofmt/go vetclean.