Draw temp targets at the BG level they target instead of in the override strip#720
Merged
Merged
Conversation
Collaborator
Test✅ successful test Reproduce the problemstart an override and temp target on the Trio test phone and confirm they are overlapped in the LoopFollow display with dev branch Confirm the fixBuild the new version of LoopFollow and confirm the Temp Target is plotted at appropriate glucose levels.
|
marionbarker
approved these changes
Jul 23, 2026
marionbarker
left a comment
Collaborator
There was a problem hiding this comment.
Approve by code review and test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Swift Charts migration put temp target bands in the same strip at the top of the graph as overrides, so the two collided and the band no longer showed which BG level the temp target aims for. Before the migration the band was drawn at the target value, 5 mg/dL above and below it, with no label, and only overrides used the top strip. This restores that behavior. Verified with an override and a temp target active at the same time, on both the main and the small graph.