ci: build the Docker images natively for amd64 and arm64#659
Merged
Conversation
- matrix build on ubuntu-latest and ubuntu-24.04-arm: each architecture builds AND boots natively, so the docker:smoke gate covers both – an emulated arm64 build could only ever boot-test amd64 - per-architecture tags (<version>-amd64/-arm64) are stitched into one multi-architecture manifest with docker buildx imagetools create, so <version> and latest resolve natively on both - the publish-manifest job inherits the skip from the build guard via needs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds the two Docker images natively for amd64 and arm64 and publishes one multi-architecture manifest per version, so Apple Silicon (and other arm64 hosts) pull a native image instead of emulating amd64.
ubuntu-latest+ubuntu-24.04-arm(free for public repos): each architecture builds and boots natively, so thedocker:smokegate now covers both. This is the deciding argument over a single QEMU cross-build, which could only ever boot-test amd64 – an arm64-only runtime failure would ship silently.<version>-amd64/<version>-arm64); a smallpublish-manifestjob stitches them into the<version>andlatesttags withdocker buildx imagetools create. The intermediate tags remain in ghcr – harmless, occasionally useful for debugging.publish-manifestjob needs no release-guard of its own:needs: buildpropagates the skip.npm ciinside the Dockerfile needs no toolchains.Verifiable end to end without waiting for a release:
gh workflow run docker.yml -f ref=@lde/search-api-server@0.0.1re-publishes 0.0.1 as a multi-arch manifest.