fix: emit RFC 5987 filename* in Attachment/Inline#3058
Open
sonnemusk wants to merge 1 commit into
Open
Conversation
Content-Disposition only set a quoted filename=, which breaks non-ASCII download names in many browsers. Keep filename= for legacy clients and add filename*=UTF-8'' with url.PathEscape.
sonnemusk
force-pushed
the
fix/content-disposition-filename-star
branch
from
July 22, 2026 07:56
5326dae to
935e1a1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3058 +/- ##
=======================================
Coverage 93.34% 93.35%
=======================================
Files 43 43
Lines 4735 4740 +5
=======================================
+ Hits 4420 4425 +5
Misses 192 192
Partials 123 123 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Attachment/Inlineonly set a quotedfilename=parameter. Non-ASCII names (e.g.报告.pdf) are often mangled by browsers.Change
filename=for legacy clients.filename*=UTF-8''…encoded withurl.PathEscape(RFC 5987 / 6266).Test plan
go test . -run 'TestContextAttachment|TestContextInline'