Skip to content

Please consider the following formatting changes to #15631 #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alibuild wants to merge 2 commits into from
Closed

Please consider the following formatting changes to #15631 #389

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
749904d
DPL: use C++26 extension to expand packs where available
ktf Jul 23, 2026
ab4246f
Please consider the following formatting changes
alibuild Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions Framework/Foundation/include/Framework/StructToTuple.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,46 @@ consteval int nested_brace_constructible_size()
return brace_constructible_size<type>() - nesting;
}

// Structured binding packs (P1061) are C++26, but clang implements them as an
// extension in every language mode and advertises them via the feature test
// macro, so we can use them while still compiling as C++20.
#if defined(__cpp_structured_bindings) && __cpp_structured_bindings >= 202411L
#define DPL_STRUCTURED_BINDING_PACKS 1
#endif

#ifdef DPL_STRUCTURED_BINDING_PACKS
namespace detail
{
template <typename... Ts>
struct first_type;
template <typename First, typename... Rest>
struct first_type<First, Rest...> {
using type = First;
};
template <typename... Ts>
using first_t = typename first_type<Ts...>::type;
} // namespace detail

#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wc++26-extensions"
#endif
template <bool B = false, class T, int D = 0, typename L>
constexpr auto homogeneous_apply_refs(L l, T&& object)
{
auto&& [... members] = object;
if constexpr (sizeof...(members) == 0) {
return std::array<bool, 0>();
} else {
return std::array<detail::first_t<decltype(l(members))...>, sizeof...(members)>{l(members)...};
}
}
#ifdef __clang__
#pragma clang diagnostic pop
#endif

#else // DPL_STRUCTURED_BINDING_PACKS

template <bool B = false, class T, int D = nested_brace_constructible_size<B, T>() / 10, typename L>
requires(D == 9)
constexpr auto homogeneous_apply_refs(L l, T&& object)
Expand Down Expand Up @@ -373,6 +413,8 @@ constexpr auto homogeneous_apply_refs(L l, T&& object)
// clang-format on
}

#endif // DPL_STRUCTURED_BINDING_PACKS

template <int D, typename T, typename L>
constexpr auto homogeneous_apply_refs_sized(L l, T&& object)
{
Expand Down