[_]: fix/etag-management#638
Open
larryrider wants to merge 5 commits into
Open
Conversation
…handler to use it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebDAV clients rely on the getetag property (and the ETag HTTP header) to detect whether a file or folder has changed, so they can decide whether to re-download or overwrite it. Our PROPFIND handler was generating this value with randomUUID() on every request, so the ETag changed constantly even when nothing about the resource had changed, making it useless for change detection and potentially causing clients to always assume conflicts or always re-sync unnecessarily.