[rig-header] Update rig.ts agentic file-summary header (7476c6d → e0ba58a)#71
Merged
Merged
Conversation
Add missing exported types and p.* helpers discovered in e0ba58a: - T:NullableSchema<Inner> — new schema type for inner|null - T:PromptVariable<T> — named prompt variable type - p.var(name,value) — PromptVariable factory - p.region(language,body) — fenced code block helper - INV:p-write-no-path — clarify that p.write() does not expand to path in templates - Clarify p.bash backslash-escaping note and p.write return semantics Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pelikhan
approved these changes
Jul 23, 2026
pelikhan
marked this pull request as ready for review
July 23, 2026 20:50
Contributor
Author
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
Contributor
Author
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /codebase-design — header accurately reflects the current API surface.
📋 Summary
Positive Highlights
- ✅ All documented symbols (
NullableSchema,PromptVariable,p.var,p.region) exist in the code and match their descriptions - ✅
p.writeno-path invariant (INV:p-write-no-path) is a useful footgun warning — well placed - ✅
p.bashbackslash-escape note andp.bashRawrecommendation correctly captures the TS-string escape distinction - ✅
T:PromptIntentkind list updated to includeenv, consistent with the implementation
No blocking issues found.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 20.1 AIC · ⌖ 5.72 AIC · ⊞ 6.3K
Comment /matt to run again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the agentic file-summary header in
skills/rig/rig.tsto reflect commite0ba58a.What changed
The previous header referenced
@last-analyzed 7476c6d, but the file was updated ine0ba58a. This PR brings the header current and adds the following previously undocumented symbols:[NEW] symbols added
T:NullableSchema<Inner>{nullable:true;inner:Inner;description?}— acceptsinner|null; produced bys.nullable()T:PromptVariable<T>{__rig:'prompt.var';name:string;value:T}— named prompt variablep.var(name,value)PromptVariable<T>binding for prompt templatesp.region(language,body)INV:p-write-no-pathp.write()contributes a write instruction to the prompt — it does NOT return the path; agents must hard-code the path in their output schemaClarifications improved
p.bashnote about TypeScript backslash escaping (preferp.bashRawfor regex-heavy commands)p.writesemantics: explicit note that template expansion does NOT yield the path stringT:Schemaunion updated to includeNullableSchemaT:PromptIntentkind list updated to include'env'Metrics
old_lines: 63 (including/**and*/)new_lines: 70changed_lines: ~12change_ratio: ~0.17 (≥ 0.10 threshold)has_new_api: true