fix(bundler): reject non-mapping 'integration' in a bundle manifest

[jawwad-ali]

What

BundleManifest.from_dict rejects a present-but-non-mapping requires and provides:

if not isinstance(requires_raw, dict):
    raise BundlerError("'requires' must be a mapping when present.")
...
if not isinstance(provides, dict):
    raise BundlerError("'provides' must be a mapping when present.")

…but integration is the odd one out — a non-mapping value is silently dropped:

integration = None
integration_raw = data.get("integration")
if isinstance(integration_raw, dict) and integration_raw.get("id"):   # bare string "copilot" fails silently
    integration = IntegrationRef(id=...)

So a manifest with integration: copilot (a common mistake — the schema wants integration: {id: copilot}) parses as a bundle that is wrongly integration-agnostic (is_agnostic() True), instead of surfacing the error.

Fix

Add the same guard as its sibling mapping fields — scoped strictly to the non-mapping-present case, leaving the existing dict-with-id behavior unchanged.

Test

test_string_integration_rejected_not_silently_dropped: integration="copilot" now raises BundlerError("'integration' must be a mapping when present") — fails before (silently dropped, no raise).

---

🤖 Written with the assistance of Claude Code (AI). Bug self-found; fix/tests verified locally (fail-before / pass-after), ruff clean.

[Copilot]

Pull request overview

Rejects malformed non-mapping integration values instead of silently treating bundles as integration-agnostic.

Changes:

• Adds explicit integration mapping validation.
• Adds a regression test for bare string values.

Show a summary per file

File	Description
src/specify_cli/bundler/models/manifest.py	Validates the optional integration field.
tests/contract/test_manifest_schema.py	Covers malformed string integration input.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Medium

[mnriem]

Thank you!