[Test Coverage] container-startup-diagnostics.ts coverage#6493
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[Test Coverage] container-startup-diagnostics.ts coverage#6493github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Add targeted tests covering previously uncovered branches: - portIssues branch (non-standard port on allowlisted domain) + fix suggestion - wildcard pattern matching with non-standard port (*.domain matching) - Additional didContainerFailStartup inspect paths - detectDnsResolutionFailure all branches (non-zero exit, EAI_AGAIN/ENOTFOUND, throws) - logContainerLogsToStderr non-zero exit and throws paths - handleHealthcheckError no-denials rethrow path Coverage improves from ~65% to ~98% on container-startup-diagnostics.ts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves test coverage for
src/container-startup-diagnostics.tsfrom ~65% to ~98%.What's covered
New tests in
src/container-startup-diagnostics-coverage.test.ts:didContainerFailStartupdocker inspectexits non-zero → returnsfalsedocker inspectthrows → returnsfalseexitedstatus →trueunhealthyhealth →truelogContainerLogsToStderrdocker logsexits non-zero → no output loggeddocker logssucceeds with empty output → no output loggeddocker logsthrows → handled gracefullydetectDnsResolutionFailuredocker logsexits non-zero →nullEAI_AGAINpattern in stdout → hostname returnedENOTFOUNDpattern in stderr → hostname returnednullnullreportBlockedDomainsportIssuesclassification + fix suggestion (lines 161-162, 181)*.domain.commatching with non-standard port → port issue (exercises lines 139-141)handleHealthcheckErrorcheckSquidLogs