Add --valuable-result-positions to search feedback#164
Open
dtaivpp wants to merge 1 commit into
Open
Conversation
Wire the API's new valuableResultPositions field through both feedback commands so agents can attribute usefulness to specific data.web results by 1-indexed position. Skills now surface positions in jq extraction snippets and require exhaustive position marking (unlisted results count as not useful), with valuableSources reserved for URLs outside data.web. Requires an API with position-based search feedback support (firecrawl/firecrawl#4109); the field is only sent when the flag is provided. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--valuable-result-positionstofirecrawl search-feedbackandfirecrawl feedback(search endpoint), forwarding the API's newvaluableResultPositionsfield (Collect search feedback result positions firecrawl#4109) so agents can attribute usefulness to specificdata.webresults by 1-indexed position.jqsnippets now print 1-indexed positions alongside URLs, and feedback guidance requires exhaustive position marking (unlisted results are treated as not useful) with--valuable-sourcesreserved for URLs outsidedata.web— no double-reporting the same result."1,3") or JSON arrays ([1,3]), same parsing as--page-numbers.Tests
npm run buildnpx vitest run— 23 files, 362 tests passing🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.