[release/8.0] Drop Microsoft.AspNetCore.Grpc.Swagger#67955
Open
Youssef1313 with Copilot wants to merge 2 commits into
Open
[release/8.0] Drop Microsoft.AspNetCore.Grpc.Swagger#67955Youssef1313 with Copilot wants to merge 2 commits into
Youssef1313 with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Youssef1313
July 22, 2026 07:20
View session
Youssef1313
marked this pull request as ready for review
July 22, 2026 07:23
Youssef1313
approved these changes
Jul 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the Microsoft.AspNetCore.Grpc.Swagger package (and its associated tests/assets) from release/8.0, along with build/solution plumbing and Sandbox usage, to reduce shipped surface area and eliminate stale dependencies.
Changes:
- Deletes the
Microsoft.AspNetCore.Grpc.Swaggersource project and its PublicAPI baselines. - Deletes the
Microsoft.AspNetCore.Grpc.Swagger.Testsproject plus supporting test services/protos. - Removes remaining wiring/references from build metadata (eng props),
src/Grpc/Grpc.slnf, and the JsonTranscoding Sandbox testasset.
Reviewed changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Grpc/JsonTranscoding/test/testassets/Sandbox/Startup.cs | Removes Swagger/OpenAPI middleware and service registration from the Sandbox test asset. |
| src/Grpc/JsonTranscoding/test/testassets/Sandbox/Sandbox.csproj | Drops the Microsoft.AspNetCore.Grpc.Swagger reference from the Sandbox test asset. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/XmlComments/XmlDocumentationIntegrationTests.cs | Deletes Grpc.Swagger XML-docs integration tests (project removal). |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/XmlComments/XmlCommentsDocumentFilterTests.cs | Deletes Grpc.Swagger XML-docs document-filter tests (project removal). |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Services/XmlDocServiceWithComments.cs | Deletes test service used by Grpc.Swagger XML comment coverage. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Services/XmlDocService.cs | Deletes test service used by Grpc.Swagger XML/proto-doc coverage. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Services/ParametersService.cs | Deletes test service used by parameter binding tests for Grpc.Swagger. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Services/GreeterService.cs | Deletes test service used by basic OpenAPI generation tests for Grpc.Swagger. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Services/BodyService.cs | Deletes test service used by body binding tests for Grpc.Swagger. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/SchemaGeneratorIntegrationTests.cs | Deletes schema generation integration tests (project removal). |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Proto/xmldoc.proto | Deletes proto used by XML documentation tests (project removal). |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Proto/parameters.proto | Deletes proto used by parameter binding tests (project removal). |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Proto/messages.proto | Deletes proto used by schema generation tests (project removal). |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Proto/greeter.proto | Deletes proto used by basic operation generation tests (project removal). |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Proto/counter.proto | Deletes proto used by grouped swagger doc tests (project removal). |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Proto/body.proto | Deletes proto used by body binding tests (project removal). |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Microsoft.AspNetCore.Grpc.Swagger.Tests.csproj | Deletes the Grpc.Swagger test project definition. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Infrastructure/TestWebHostEnvironment.cs | Deletes test infrastructure type (project removal). |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Infrastructure/OpenApiTestHelpers.cs | Deletes OpenAPI test helper infrastructure (project removal). |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/GrpcSwaggerServiceExtensionsTests.cs | Deletes extension-method behavior tests (project removal). |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/google/api/http.proto | Deletes vendored google.api.http proto used by tests (project removal). |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/google/api/annotations.proto | Deletes vendored google.api.annotations proto used by tests (project removal). |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Binding/ParametersTests.cs | Deletes parameter binding tests (project removal). |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Binding/BodyTests.cs | Deletes body binding tests (project removal). |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/PublicAPI.Unshipped.txt | Deletes PublicAPI baseline file (package removal). |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/PublicAPI.Shipped.txt | Deletes shipped API baseline file (package removal). |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Microsoft.AspNetCore.Grpc.Swagger.csproj | Deletes the Grpc.Swagger package project. |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Internal/XmlComments/GrpcXmlCommentsOperationFilter.cs | Deletes internal XML comment operation filter implementation (package removal). |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Internal/XmlComments/GrpcXmlCommentsDocumentFilter.cs | Deletes internal XML comment document filter implementation (package removal). |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Internal/MessageDescriptorHelpers.cs | Deletes internal protobuf descriptor helper code (package removal). |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Internal/GrpcModelMetadata.cs | Deletes internal ModelMetadata implementation (package removal). |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Internal/GrpcJsonTranscodingDescriptionProvider.cs | Deletes internal ApiExplorer description provider used for OpenAPI generation (package removal). |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Internal/GrpcDataContractResolver.cs | Deletes internal Swashbuckle data contract resolver (package removal). |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/GrpcSwaggerServiceExtensions.cs | Deletes public DI extensions (AddGrpcSwagger) (package removal). |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/GrpcSwaggerGenOptionsExtensions.cs | Deletes public SwaggerGen extensions (IncludeGrpcXmlComments) (package removal). |
| src/Grpc/Grpc.slnf | Removes Grpc.Swagger projects from the gRPC solution filter. |
| eng/ShippingAssemblies.props | Stops shipping Microsoft.AspNetCore.Grpc.Swagger as part of the shared framework assembly list. |
| eng/RequiresDelayedBuildProjects.props | Removes Grpc.Swagger projects from the delayed-build project list. |
| eng/ProjectReferences.props | Removes Grpc.Swagger from centralized project reference providers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JamesNK
approved these changes
Jul 22, 2026
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
This was referenced Jul 22, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #67919 to
release/8.0. Removes theMicrosoft.AspNetCore.Grpc.Swaggerpackage entirely.Description
src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/(full package source)src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/(full test project)eng/ShippingAssemblies.props,eng/ProjectReferences.props,eng/RequiresDelayedBuildProjects.props, andsrc/Grpc/Grpc.slnfSandbox.csproj,Startup.cs) of Swagger usageCustomer Impact
Removes a package that should no longer ship on release/8.0, reducing surface area and eliminating stale dependencies.
Regression?
Risk
Pure deletion — no logic changes, no new code.
Verification
Packaging changes reviewed?
When servicing release/2.1