Enable nullable reference types in RtxtWriter.cs#12241
Open
jonathanpeppers with Copilot wants to merge 2 commits into
Open
Enable nullable reference types in RtxtWriter.cs#12241jonathanpeppers with Copilot wants to merge 2 commits into
jonathanpeppers with Copilot wants to merge 2 commits into
Conversation
6 tasks
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enable nullable reference types in RtxtWriter.cs
Enable nullable reference types in RtxtWriter.cs
Jul 27, 2026
jonathanpeppers
marked this pull request as ready for review
July 27, 2026 13:04
jonathanpeppers
approved these changes
Jul 27, 2026
jonathanpeppers
enabled auto-merge (squash)
July 27, 2026 13:05
Contributor
There was a problem hiding this comment.
Pull request overview
This PR opts src/Xamarin.Android.Build.Tasks/Utilities/RtxtWriter.cs into nullable reference types (NRT) as part of the repo-wide enablement effort, adding explicit runtime guards for reference-type inputs to preserve behavior and eliminate nullable warnings.
Changes:
- Enabled NRT with
#nullable enableat the top ofRtxtWriter.cs. - Added
ArgumentNullExceptionguards forfileanditemsusing anetstandard2.0-compatible pattern.
rolfbjarne
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opts
RtxtWriter.csinto NRT as part of the repo-wide nullable enablement effort.Changes
#nullable enableas the first line ofRtxtWriter.csfileanditemsparameters usingnetstandard2.0-compatible form (ArgumentNullException.ThrowIfNullis unavailable on that TFM):Ris astruct, soIList<R>requires no element-level null annotations and no!operator is needed anywhere.