Remove redundant AsyncTask logging from LinkNativeRuntime - #12238
Merged
jonathanpeppers merged 2 commits intoJul 27, 2026
Conversation
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix obsolete Log.LogError with thread-safe logging in LinkNativeRuntime task
Remove redundant AsyncTask logging from LinkNativeRuntime
Jul 26, 2026
jonathanpeppers
marked this pull request as ready for review
July 27, 2026 13:40
jonathanpeppers
enabled auto-merge (squash)
July 27, 2026 13:40
Contributor
There was a problem hiding this comment.
Pull request overview
Removes redundant and unsafe error logging from the LinkNativeRuntime MSBuild task by relying on NativeLinker’s existing coded/localized error reporting for native link failures.
Changes:
- Drop the
bool successlocal and invokeNativeLinker.Link(...)directly. - Remove the extra
Log.LogError(...)path that emitted a non-localized message from anAsyncTaskbackground thread. - Preserve existing
XA3007/XA3008failure diagnostics emitted byNativeLinker.
rolfbjarne
approved these changes
Jul 27, 2026
jonathanpeppers
disabled auto-merge
July 27, 2026 19:45
jonathanpeppers
deleted the
copilot/fix-finder-replace-obsolete-log-error
branch
July 27, 2026 19:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LinkNativeRuntimewas logging a second failure message via the obsoleteAsyncTask.Logproperty after native linking failed.NativeLinkeralready reports those failures through localized coded errors (XA3007/XA3008), so the extra log path was both unsafe and redundant.LinkNativeRuntime cleanup
Log.LogError (...)call fromLinkRuntime.successlocal and invokeNativeLinker.Link (...)directly.Error reporting behavior
NativeLinkererror paths.Resulting code shape