Skip to content

Document DSR overlay networks#25613

Merged
dvdksn merged 1 commit into
docker:mainfrom
dvdksn:fix/issue-9652-overlay-dsr
Jul 23, 2026
Merged

Document DSR overlay networks#25613
dvdksn merged 1 commit into
docker:mainfrom
dvdksn:fix/issue-9652-overlay-dsr

Conversation

@dvdksn

@dvdksn dvdksn commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Document the DSR option for Linux east-west overlay traffic and restore the legacy overlay tutorial redirect.

Closes #9652

Generated by Codex

The overlay networking docs omitted the supported DSR driver option. Document Linux east-west DSR usage and restore the legacy tutorial redirect.

Co-Authored-By: Codex <noreply@openai.com>
@netlify

netlify Bot commented Jul 21, 2026

Copy link
Copy Markdown

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 5a90cf9
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/6a5f46c04d30cb0008e69f69
😎 Deploy Preview https://deploy-preview-25613--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dvdksn dvdksn added the status/review Pull requests that are ready for review label Jul 21, 2026
@github-actions github-actions Bot added area/engine Issue affects Docker engine/daemon area/networking Relates to anything around networking area/swarm Issue affects swarm and clustering functionality of docker labels Jul 21, 2026
@dvdksn
dvdksn requested review from a team and akerouanton July 21, 2026 10:15

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

The changes look good. The PR adds a well-structured DSR subsection to the overlay networking documentation and restores a missing redirect alias.

  • ****: The new entry () correctly restores the legacy overlay tutorial redirect. No issues.
  • ****: The new "Use direct server return" subsection is accurate and clear. The --opt dsr bare-key syntax is consistent with Docker's established convention for boolean network options (same pattern as --opt encrypted). The NOTE callout correctly uses the supported > [!NOTE] syntax and flags the Linux-only constraint.

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

The PR adds a DSR (Direct Server Return) section to the swarm networking guide and restores a missing legacy redirect alias.

Redirect alias: The alias is correctly added to front matter — no redirect gap.

New DSR section: The bare-flag syntax is consistent with the existing pattern used elsewhere in overlay network documentation. The new content is concise, accurate, and follows the project's code-example pattern (state → show → explain + note). No AI-isms or style violations found.

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

The PR adds a concise "Use direct server return" subsection to networking.md and restores a missing redirect alias in overlay.md. Both changes are well-scoped and accurate.

What was checked:

  • --opt dsr bare-flag syntax — mirrors the established --opt encrypted pattern in the same file; not a bug
  • Redirect alias /network/network-tutorial-overlay/ added to overlay.md front matter — correct, no missing redirects
  • Style guide compliance (AI-isms, hedge words, bold usage, list formatting) — clean
  • Markdown formatting — no issues
  • Content accuracy — DSR description (MAC rewrite, unchanged source/VIP) is technically accurate
  • NOTE callout about Linux-only + ingress exclusion — appropriate and correctly formatted

No issues found in the changed code.

@dvdksn
dvdksn merged commit 3eade38 into docker:main Jul 23, 2026
18 checks passed
@dvdksn
dvdksn deleted the fix/issue-9652-overlay-dsr branch July 23, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/engine Issue affects Docker engine/daemon area/networking Relates to anything around networking area/swarm Issue affects swarm and clustering functionality of docker status/review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add documentation for dsr option for Overlay Networks

3 participants