vendor: github.com/docker/go-connections main (v0.8.0-dev)#7121
Draft
thaJeztah wants to merge 1 commit into
Draft
vendor: github.com/docker/go-connections main (v0.8.0-dev)#7121thaJeztah wants to merge 1 commit into
thaJeztah wants to merge 1 commit into
Conversation
- sockets: set socket permissions without overriding umask - sockets: improve abstract Unix socket handling - sockets: InmemSocket: add DialContext - sockets: remove double error decoration - sockets: test-enhancements and improve coverage full diff: docker/go-connections@v0.7.0...754f906 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The vendored update to github.com/docker/go-connections (v0.7.0 → v0.8.0-dev) looks clean. The changes reviewed:
inmem_socket.go:DialContextis correctly implemented with proper context-cancellation handling and cleanup — both ends of the pipe are closed on timeout/cancellation, with no goroutine or connection leaks.unix_socket_unix.go: The new manual socket lifecycle (socket→bind→chmod→listen) is a genuine security improvement over the previous umask-manipulation approach.listen(2)is now only called after permissions are set, so clients can never connect to an under-permissioned socket.unix_socket.go: Abstract socket path handling is correct;ErrUnsupportedis properly returned for unsupported options.unix_socket_windows.go: WindowslistenUnixnow correctly accepts and applies opts, matching unix behaviour.
No bugs found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
full diff: docker/go-connections@v0.7.0...754f906
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)