Skip to content

docs: clarify LostInTheMiddleRanker threshold units#12092

Draft
zcxGGmu wants to merge 1 commit into
deepset-ai:mainfrom
zcxGGmu:docs/11351-lost-middle-threshold-units
Draft

docs: clarify LostInTheMiddleRanker threshold units#12092
zcxGGmu wants to merge 1 commit into
deepset-ai:mainfrom
zcxGGmu:docs/11351-lost-middle-threshold-units

Conversation

@zcxGGmu

@zcxGGmu zcxGGmu commented Jul 21, 2026

Copy link
Copy Markdown

Related Issues

Proposed Changes:

  • Clarify that LostInTheMiddleRanker.word_count_threshold counts whitespace-separated words, not tokenizer-aware tokens.
  • Add the same clarification to the current and 2.31 versioned docs page.
  • Keep runtime behavior unchanged, matching the maintainer guidance in feat: support token-based budget in LostInTheMiddleRanker #11351.

How did you test it?

  • hatch run fmt-check haystack/components/rankers/lost_in_the_middle.py
  • hatch -e test run pytest test/components/rankers/test_lost_in_the_middle.py
  • git diff --check

Notes for the reviewer

No release note was added because this is a docs/docstring-only clarification with no behavior change.

This PR was generated with an AI assistant. I reviewed the changes and ran the relevant tests.

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights, or the PR body contains the relevant context.
  • I have added unit tests and updated the docstrings, where applicable.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines, or the change is docs-only / not user-facing runtime behavior.
  • I have run pre-commit hooks and fixed any issue, or run the focused equivalent checks listed above.

@zcxGGmu
zcxGGmu requested a review from a team as a code owner July 21, 2026 07:41
@zcxGGmu
zcxGGmu requested review from sjrl and removed request for a team July 21, 2026 07:41
@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

@MaskerFather is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@HaystackBot

Copy link
Copy Markdown
Contributor

Hi @zcxGGmu, thanks a lot for your contribution! 🙏

We noticed that the Contributor License Agreement (CLA) check (license/cla) hasn't passed yet, so we've temporarily moved this PR to draft and paused the review assignment.

To get your PR reviewed, please sign the CLA via the link in the license/cla check below (or in the CLA bot comment). As soon as the check turns green, this PR will automatically be marked ready for review again and a reviewer will be re-assigned.

@HaystackBot
HaystackBot removed the request for review from sjrl July 21, 2026 09:13
@HaystackBot HaystackBot added the cla-pending PR is in draft until the contributor signs the CLA label Jul 21, 2026
@HaystackBot
HaystackBot marked this pull request as draft July 21, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-pending PR is in draft until the contributor signs the CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants