RG config client — CRUD, models and versioned generate methods - #38
Open
carlosfunk wants to merge 4 commits into
Open
RG config client — CRUD, models and versioned generate methods#38carlosfunk wants to merge 4 commits into
carlosfunk wants to merge 4 commits into
Conversation
carlosfunk
marked this pull request as draft
July 19, 2026 23:01
carlosfunk
changed the title
carlosfunk
force-pushed
the
dm-3731-rg-config
branch
from
July 27, 2026 01:15
43f4d05 to
b610a34
Compare
- add RGConfig pydantic model and RGConfigClient mixin: list/get/create/update/delete + defaults yaml - add generate_ruleset_with_rg_config (v3) and file/async/csv variants (v2), mirroring the discovery from_config split - old generate request models reject rg_config and point callers at the new methods - document dependent-RGC behaviour on ruleset library delete/usage APIs
carlosfunk
force-pushed
the
dm-3731-rg-config
branch
from
July 27, 2026 02:58
b610a34 to
dd05444
Compare
carlosfunk
marked this pull request as ready for review
July 27, 2026 03:00
cph-datamasque
left a comment
cph-datamasque
left a comment
Collaborator
There was a problem hiding this comment.
Mostly minor issues.
Do we want a RGConfigNotFoundError exception type to mirror the handling of 400 responses for other APIs?
Another thing that needs to be done at some point: the docs are out of date and need regenerating. Up to you if you want to do that in this MR, or we could raise a ticket to do it another day.
* Add `RGConfigNotFoundError`, raised by all four `*_with_rg_config` methods when the server rejects the config id. * Guard `update_rg_config` against a YAML-less config, matching the discovery config library client. * Resolve `delete_rg_config_by_name_if_exists` with the `name_exact` filter instead of enumerating every config. * Fold the duplicated `rg_config` request-body handling into `_post_with_rg_config`. * Drop API version numbers from the `rg_config`-rejection error messages and the changelog. * Apply semantic line breaks to the RG config docstrings and add the missing docs stubs.
Member
Author
Added.
Added the two stubs for this PR. |
cph-datamasque
approved these changes
Jul 28, 2026
cph-datamasque
left a comment
cph-datamasque
left a comment
Collaborator
There was a problem hiding this comment.
Approved after one wording change
| """ | ||
| Raised when ruleset generation references an RG config that cannot be found. | ||
| The config does not exist, or has been archived. |
Collaborator
There was a problem hiding this comment.
archived -> deleted
- The admin server now persists a list of validation errors alongside the single-line summary, so surface them as `validation_errors` rather than making callers parse `validation_error` - Correct the `is_valid` docstring, which described the removed asynchronous validation flow
- RG configs take no `version` key, and a label's mask goes under `preset_mask` rather than being mapped to a bare string - The client treats `config_yaml` as an opaque string, so no test caught this; the fixture's only reader is whoever copies it as an example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds client support for DataMasque ruleset-generation configs: server-side masks-per-label configs consumed by the versioned generate APIs.
Commits
feat(client): add RG config CRUD and versioned generate methodsWhat's in it
RGConfigpydantic model +RGConfigClientmixin:list/get/create/update/delete+get_default_rg_config_yaml()againstrg/configs/*_from_configsplit:generate_ruleset_with_rg_config(v3),generate_file_ruleset_with_rg_config(v2),start_async_ruleset_generation_with_rg_config(v2),start_async_ruleset_generation_from_csv_with_rg_config(v2). Old methods keep the old endpoints (server default RG config).rg_configand point callers at the new methods.rg_config=Noneis sent as an empty form field; DRF coerces''to null on relational fields (verified end-to-end against a live server).