fix: make lock acquisition signal-safe - #7
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
- Purpose: harden
install.shlock acquisition againstINT/TERMarriving between successfulmkdirof the lock directory and recording ownership for cleanup, and add a regression test to prevent stale lock regressions.
Changes:
- Add
enable_signal_traps()helper and use it frommain()to centralizeINT/TERMhandling. - Make lock acquisition +
LOCK_DIRassignment effectively indivisible with temporary signal handling changes aroundmkdir. - Add a deterministic Bats regression test that injects a
TERMimmediately after the lock directory is created.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| install.sh | Adjusts signal handling during lock acquisition so cleanup can’t strand a lock directory. |
| tests/install.bats | Adds a regression test that simulates a signal arriving immediately after lock creation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
INT/TERMcleanupmkdircreates the lockWhy
A signal arriving after
mkdirsucceeded but beforeLOCK_DIRwas assigned could leave a permanent stale lock. Later installations would wait for 120 seconds and fail until the directory was removed manually.Impact
Interrupted acquisition can no longer strand the installation lock, while waiting installers still cannot remove a lock owned by another process.
Validation
shellcheck --shell=sh --severity=style install.shbats tests/(43 tests passed)git diff --check