Skip to content

ENT-3787: Remove obsolete audit-mode soft-fail acceptance tests#6242

Merged
larsewi merged 1 commit into
cfengine:masterfrom
nickanderson:ENT-3787-remove-soft-fail
Jul 23, 2026
Merged

ENT-3787: Remove obsolete audit-mode soft-fail acceptance tests#6242
larsewi merged 1 commit into
cfengine:masterfrom
nickanderson:ENT-3787-remove-soft-fail

Conversation

@nickanderson

@nickanderson nickanderson commented Jul 22, 2026

Copy link
Copy Markdown
Member

The tests/acceptance/28_inform_testing/02_soft_fail_files suite was a parallel of 01_files/ that encoded aspirational inform messages for the audit / simulate feature (ENT-3787) — a promise-summary line plus a
single consolidated detail line, e.g.:

info: files promise '/tmp/TEST.cfengine' repaired, changes => example
info: Detected changes for '/tmp/TEST.cfengine', md5 hash '…', sha1 hash '…'

Those messages were never implemented.

ENT-3787 is closed (Done). Let's get rid of soft failing tests wasting time.

These 28_inform_testing soft-fail tests encoded aspirational inform
messages for the audit/simulate feature (ENT-3787) that never landed, so
they soft-failed permanently. The ticket is closed; remove the suite and
common_soft_fail.cf.sub, and collapse copy_from01/03 to common.cf.sub
(dropping the now-dead hpux.ia64 path).
@nickanderson
nickanderson force-pushed the ENT-3787-remove-soft-fail branch from 48f3f3b to 090fee5 Compare July 22, 2026 04:36
@nickanderson
nickanderson requested a review from olehermanse July 22, 2026 06:01
@nickanderson
nickanderson marked this pull request as ready for review July 22, 2026 15:44
@olehermanse

Copy link
Copy Markdown
Member

@cf-bottom jenkins, please

@olehermanse olehermanse added the cherry-pick? Fixes which may need to be cherry-picked to LTS branches label Jul 22, 2026
@olehermanse
olehermanse requested a review from larsewi July 22, 2026 17:16
@cf-bottom

Copy link
Copy Markdown

@larsewi

larsewi commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

^ Test failure above is unrelated

@larsewi
larsewi merged commit ce23d58 into cfengine:master Jul 23, 2026
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick? Fixes which may need to be cherry-picked to LTS branches

Development

Successfully merging this pull request may close these issues.

4 participants