[Bug] Prevent hard process exit on Ctrl+C if an onCancel callback is passed to spinner#587
Open
kajoseph wants to merge 2 commits into
Open
[Bug] Prevent hard process exit on Ctrl+C if an onCancel callback is passed to spinner#587kajoseph wants to merge 2 commits into
kajoseph wants to merge 2 commits into
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With the spinner running,
Ctrl+Chard-exits the node process with a buriedprocess.exit(0)as noted by @43081j here. This short-circuits the spinner stop cycle which prevents theonCancelcallback from running and also potentially leaves dangling connections to other services (e.g. a database).This PR changes the behavior slightly so that an
onCancelcallback will prevent the cancellation cycle from callingprocess.exit()and instead return control back to the program so that it can cleanly teardown connections or otherwise proceed as desired. This modified behavior is more in-line with the rest of the prompts in that aCtrl+Creturns control back to the program instead of treating it as a SIGINT.Closes #573
Type of change
Checklist
pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure
* only the added test cases were generated with AI as I'm not as familiar with this test harness. Suggest verifying that it's testing properly.